Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add eTLD validation support #536

Closed
tarunKoyalwar opened this issue Jun 26, 2023 · 1 comment · Fixed by #537
Closed

add eTLD validation support #536

tarunKoyalwar opened this issue Jun 26, 2023 · 1 comment · Fixed by #537
Labels
defcon31 Type: Enhancement Most issues will probably ask for additions or changes.

Comments

@tarunKoyalwar
Copy link
Member

Description

usually eTLD's don't resolve to ip . since its general use case is to act like TLD however lot of orgs host services on eTLD.
Example below are eTLD and some of them have resolve which some not

echo -e "ngrok.io\nco.uk\nai" | dnsx -resp

      _             __  __
   __| | _ __   ___ \ \/ /
  / _' || '_ \ / __| \  / 
 | (_| || | | |\__ \ /  \ 
  \__,_||_| |_||___//_/\_\

		projectdiscovery.io

[INF] Current dnsx version 1.1.4 (latest)
ngrok.io [34.210.2.84] 
ai [209.59.119.34] 

ValidateFQDN function used for validation of root domains does not consider this use case which classifies ngrok.io and ai as invalid domains here but some of them are valid (ex: http://ai 😆 )

Proposed Changes

  • for proper validation check if given domain is eTLD if so try to resolve it using retryabledns if resolved then it is considered as valid domain if not then it is suffix(i.e not valid for this repo)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defcon31 Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants