eTLD validation support in ValidateFQDN #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tarunKoyalwar @ehsandeep I created this draft PR per the new issue. Would something like this be more appropriate? |
This was
linked to
issues
Jun 27, 2023
ehsandeep
approved these changes
Jun 27, 2023
tarunKoyalwar
approved these changes
Jun 28, 2023
|
Thank you @MattSilvaa, for fixing this one! |
|
Thanks for this @MattSilvaa - you can check out https://defcon.projectdiscovery.io/countdown as this issue is part of this program 😄 |
Thanks for sharing! I will sign up and look forward to contributing more 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR for #536 and #532