Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension of TCP Server (livereload, binary matching, custom logic) #61

Merged
merged 3 commits into from Dec 23, 2021

Conversation

c-f
Copy link
Contributor

@c-f c-f commented Dec 20, 2021

This PR extends. the TCP server:

  • Previous longer responses are leaked into newer requests
> First request might be very long
> Second Request

## results in buf to be 
First request might be very long
Second Request(\n)e very long
  • LiveReload of rules. No need to restart the server if rules are modified
  • allows matches to be literal matches. Binary data are often not valid UFT-8 characters, therefore regex does not always work.
  • Allow injection of custom logic into tcpserver via the HandleMessageFn

@ehsandeep ehsandeep changed the base branch from master to dev December 21, 2021 10:17
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@c-f Thanks and great work! I think I'm going to change also the custom implementation of filewatcher at https://github.com/projectdiscovery/interactsh/blob/main/pkg/filewatcher/filewatcher.go with https://github.com/fsnotify/fsnotify (at implementation time it was not working correctly on OSX/Windows)

@Mzack9999 Mzack9999 added the Type: Enhancement Most issues will probably ask for additions or changes. label Dec 21, 2021
@c-f
Copy link
Contributor Author

c-f commented Dec 22, 2021

@c-f Thanks and great work! I think I'm going to change also the custom implementation of filewatcher at https://github.com/projectdiscovery/interactsh/blob/main/pkg/filewatcher/filewatcher.go with https://github.com/fsnotify/fsnotify (at implementation time it was not working correctly on OSX/Windows)

:) great to hear that. Additional after this merge is done, i'll also create a MR for interactsh to add the tcp server

@ehsandeep ehsandeep merged commit bbfd855 into projectdiscovery:dev Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants