Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove scheme #1166

Merged
merged 3 commits into from Mar 26, 2024
Merged

remove scheme #1166

merged 3 commits into from Mar 26, 2024

Conversation

dogancanbakir
Copy link
Member

Closes #1152

@dogancanbakir dogancanbakir self-assigned this Feb 21, 2024
@dogancanbakir
Copy link
Member Author

ignore failing test, fixed in #1167

Mzack9999
Mzack9999 approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - What do you think about declaring a global var and reusing it this way:

r := strings.NewReplacer(
	"*.", "",
	"http://", "",
	"https://", "",
)
...
subdomain = r.Replace(subdomain)

@ehsandeep ehsandeep merged commit e5ee088 into dev Mar 26, 2024
8 checks passed
@ehsandeep ehsandeep deleted the remove_scheme branch March 26, 2024 14:30
@BrewTestBot BrewTestBot mentioned this pull request Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

@dogancanbakir dogancanbakir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected HTTP/HTTPS Prefix in Subdomain Enumeration Results
3 participants
@dogancanbakir @ehsandeep @Mzack9999