Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix lib log config issue #1200

Merged
merged 2 commits into from Mar 26, 2024
Merged

fix lib log config issue #1200

merged 2 commits into from Mar 26, 2024

Conversation

dogancanbakir
Copy link
Member

Closes #1199

@dogancanbakir dogancanbakir self-assigned this Mar 26, 2024
@dogancanbakir
Copy link
Member Author

we can ignore failing test for now.

Mzack9999
Mzack9999 approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - is the https://certificatedetails.com/ source broken probably? I'm unable to see any certificate as well from browser

@dogancanbakir
Copy link
Member Author

I've disabled the tests for now, #1202. We can do further investigation and remove it if necessary.

@ehsandeep ehsandeep merged commit e8cb3d9 into dev Mar 26, 2024
8 checks passed
@ehsandeep ehsandeep deleted the fix_lib_log_config_issue branch March 26, 2024 14:29
@BrewTestBot BrewTestBot mentioned this pull request Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

@dogancanbakir dogancanbakir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Silent flag doesn't work in SDK. Library too verbose
3 participants
@dogancanbakir @ehsandeep @Mzack9999