Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new source dnsrepo #501

Merged
merged 7 commits into from
Sep 20, 2022
Merged

new source dnsrepo #501

merged 7 commits into from
Sep 20, 2022

Conversation

LuitelSamikshya
Copy link
Contributor

@LuitelSamikshya LuitelSamikshya commented Feb 16, 2022

This PR adds support for new source https://dnsrepo.noc.org/
closes #643 and #475

@LuitelSamikshya LuitelSamikshya self-assigned this Feb 16, 2022
@LuitelSamikshya LuitelSamikshya linked an issue Feb 16, 2022 that may be closed by this pull request
@LuitelSamikshya LuitelSamikshya added the Type: Enhancement Most issues will probably ask for additions or changes. label Feb 16, 2022
@sonarcloud
Copy link

sonarcloud bot commented Feb 16, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
16.9% 16.9% Duplication

Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API needs to be supported in this case, waiting for further information as commented here #475 (comment)

@ehsandeep ehsandeep added the Status: On Hold Similar to blocked, but is assigned to someone label Feb 21, 2022
Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LuitelSamikshya Instead of scrapping, we can utilize the API endpoint to pull all the results, including the integration test.

API Endpoint:

https://dnsrepo.noc.org/api/?apikey=API_KEY&search=hackerone.com

API Details: https://dnsrepo.noc.org/?apiaccess

@ehsandeep ehsandeep added Status: Revision Needed Submitter of PR needs to revise the PR related to the issue. and removed Status: On Hold Similar to blocked, but is assigned to someone labels Sep 8, 2022
@LuitelSamikshya LuitelSamikshya marked this pull request as draft September 9, 2022 17:59
@LuitelSamikshya LuitelSamikshya marked this pull request as ready for review September 16, 2022 18:27
Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

./subfinder -s dnsrepo -d hackerone.com

               __    _____           __         
   _______  __/ /_  / __(_)___  ____/ /__  _____
  / ___/ / / / __ \/ /_/ / __ \/ __  / _ \/ ___/
 (__  ) /_/ / /_/ / __/ / / / / /_/ /  __/ /    
/____/\__,_/_.___/_/ /_/_/ /_/\__,_/\___/_/ v2.5.3

		projectdiscovery.io

Use with caution. You are responsible for your actions
Developers assume no liability and are not responsible for any misuse or damage.
By using subfinder, you also agree to the terms of the APIs used.

[INF] Loading provider config from '/Users/geekboy/.config/subfinder/provider-config.yaml'
[INF] Enumerating subdomains for 'hackerone.com'
docs.hackerone.com
api.hackerone.com
b.ns.hackerone.com
gslink.hackerone.com
gsemail.hackerone.com
mta-sts.managed.hackerone.com
www.hackerone.com
support.hackerone.com
zendesk3.hackerone.com
a.ns.hackerone.com
mta-sts.hackerone.com
zendesk2.hackerone.com
[INF] Found 12 subdomains for 'hackerone.com' in 1 second 297 milliseconds

@ehsandeep ehsandeep added Status: Review Needed The issue has a PR attached to it which needs to be reviewed and removed Status: Revision Needed Submitter of PR needs to revise the PR related to the issue. Type: Enhancement Most issues will probably ask for additions or changes. labels Sep 16, 2022
@ehsandeep ehsandeep merged commit b6ed45c into dev Sep 20, 2022
@ehsandeep ehsandeep deleted the dnsrepo-source branch September 20, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Review Needed The issue has a PR attached to it which needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up integration-test and add integration test for the dnsrepo source [new data source] dnsrepo.noc.org
4 participants