Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test for sources w/o auth #649 #651

Conversation

dogancanbakir
Copy link
Member

This PR adds integration tests for sources w/o auth

Copy link
Member

@Ice3man543 Ice3man543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dogancanbakir the tests are failing for some reason. can you please fix them?

@forgedhallpass
Copy link
Contributor

I've refactored the test to make detecting problems easier (will commit it later). The point is that based on that I've noticed that there are 3 or 4 providers that are not working currenlty. One has anti-automation (captcha) and 2 or 3 other services are not accessible anymore (gateway error and temporarily unavailabe).

@dogancanbakir
Copy link
Member Author

dogancanbakir commented Sep 27, 2022

@Ice3man543 As @forgedhallpass pointed out, some of the providers are not working. And we should see them failing; seeing integration tests are failing means one thing, providers are not working as expected. That will make us investigate them further. Additionally, we should consider separating integration tests from the current pipeline, and maybe running them as a cron job might be a good idea.

@Ice3man543
Copy link
Member

@forgedhallpass we should create issues regarding failing providers and ideally remove them since querying them is a waste of time.

@forgedhallpass
Copy link
Contributor

@forgedhallpass we should create issues regarding failing providers and ideally remove them since querying them is a waste of time.

That's was the plan, but only for tomorrow :)

@forgedhallpass forgedhallpass changed the base branch from dev to tests September 28, 2022 13:52
@forgedhallpass forgedhallpass merged commit 776499e into projectdiscovery:tests Sep 28, 2022
@dogancanbakir dogancanbakir deleted the integration_test_for_sources_wo_auth_#649 branch June 22, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create/aggregate tests for providers that do NOT require an API key
3 participants