Issue 761 upgrade deps #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bump github.com/projectdiscovery/ratelimit from v0.0.2 to v0.0.6
- Replace github.com/projectdiscovery/fileutil with github.com/projectdiscovery/utils/file
- Remove &gitlab.Source{} from AllSources array
4 tasks
tarunKoyalwar
approved these changes
Feb 16, 2023
There was a problem hiding this comment.
lgtm!
$ go run . -d hackerone.com
__ _____ __
_______ __/ /_ / __(_)___ ____/ /__ _____
/ ___/ / / / __ \/ /_/ / __ \/ __ / _ \/ ___/
(__ ) /_/ / /_/ / __/ / / / / /_/ / __/ /
/____/\__,_/_.___/_/ /_/_/ /_/\__,_/\___/_/ v2.5.5
projectdiscovery.io
Use with caution. You are responsible for your actions
Developers assume no liability and are not responsible for any misuse or damage.
By using subfinder, you also agree to the terms of the APIs used.
[INF] Loading provider config from '/Users/tarun/.config/subfinder/provider-config.yaml'
[INF] Enumerating subdomains for 'hackerone.com'
3d.hackerone.com
web-seo-content-for-business.theflyingkick.websitedesignresource.api.hackerone.com
zendesk2.hackerone.com
zendesk4.hackerone.com
email.gh-mail.hackerone.com
a.ns.hackerone.com
support.hackerone.com
go.hackerone.com
gslink.hackerone.com
zendesk1.hackerone.com
zendesk3.hackerone.com
mta-sts.forwarding.hackerone.com
b.ns.hackerone.com
links.hackerone.com
info.hackerone.com
mta-sts.hackerone.com
fsdkim.hackerone.com
events.hackerone.com
design.hackerone.com
docs.hackerone.com
hackerone.com
resources.hackerone.com
defcon.hackerone.com
api.hackerone.com
mta-sts.managed.hackerone.com
_dmarc.hackerone.com
www.hackerone.com
[INF] Found 27 subdomains for 'hackerone.com' in 10 seconds 155 milliseconds
Mzack9999
approved these changes
Feb 16, 2023
There was a problem hiding this comment.
lgtm - I've other two suggestions:
- Add https://github.com/projectdiscovery/utils/blob/1d3007facb2ca1f84c48ba23773b0e30c3068201/log/logutil.go#L10 since in the output is appearing the following:
2023/02/16 20:20:57 driver.NamedValue{Name:"", Ordinal:1, Value:"%.xxx.xxx"}
- Replace hasStdin with fileutils.HasStdin
RamanaReddy0M
requested review from
Mzack9999,
ShubhamRasal and
tarunKoyalwar
Mzack9999
approved these changes
Feb 17, 2023
|
Am excited for this PR to be merged 🤩 |
tarunKoyalwar
requested review from
ehsandeep
and removed request for
ShubhamRasal and
tarunKoyalwar
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update dependencies: (#761)