Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add conn deadlines and fix retry logic in auto mode #284

Merged
merged 5 commits into from
Jun 19, 2023
Merged

Conversation

tarunKoyalwar
Copy link
Member

@tarunKoyalwar tarunKoyalwar commented Jun 15, 2023

Description

POC

  • setup up open port
 $  sudo nc -dkl 440 
Password:
  • run tlsx aganist this port
$  cmdutil ./tlsx -u localhost -p 440 -v        
  

  _____ _    _____  __
 |_   _| |  / __\ \/ /
   | | | |__\__ \>  < 
   |_| |____|___/_/\_\	v1.0.9

		projectdiscovery.io

[INF] Current tlsx version v1.0.9 (latest)
[INF] Processing input localhost:440
[WRN] Could not connect input localhost:440: [auto:RUNTIME] [ctls:RUNTIME] read tcp 127.0.0.1:55288->127.0.0.1:440: i/o timeout <- could not do handshake; [ztls:RUNTIME] failed to setup connection <- [:RUNTIME] could not connect to any address found for host <- could not dial address; [LibreSSL3.3.6,/usr/bin/openssl,LibreSSL3.3.6:RUNTIME] failed to response from openssl <- Command: /usr/bin/openssl s_client -connect localhost:440 -servername localhost -tls1_2 <- failed to execute openssl got  <- signal: killed <- could not connect to host
[INF] Connections made using crypto/tls: 0, zcrypto/tls: 0, openssl: 0

------------------------------
Command: ./tlsx -u localhost -p 440 -v
Max RSS: 32 MB
Sys Time: 38.671µs
User Time: 58.122µs
Actual Time: 10.241563s
Voluntary Context Switch (nvcsw): 42

Note: by default we have retry count set to 3

@tarunKoyalwar tarunKoyalwar self-assigned this Jun 15, 2023
@tarunKoyalwar
Copy link
Member Author

more context here projectdiscovery/nuclei#3792 (comment)

@tarunKoyalwar tarunKoyalwar linked an issue Jun 15, 2023 that may be closed by this pull request
@Mzack9999 Mzack9999 merged commit 0a8db8a into dev Jun 19, 2023
10 checks passed
@Mzack9999 Mzack9999 deleted the fix-timeout-issue branch June 19, 2023 10:54
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add conn R/W deadline
2 participants