Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rate limiting logic #165

Merged
merged 15 commits into from
Mar 8, 2023
Merged

Rate limiting logic #165

merged 15 commits into from
Mar 8, 2023

Conversation

xm1k3
Copy link
Contributor

@xm1k3 xm1k3 commented Feb 28, 2023

No description provided.

@xm1k3 xm1k3 added the Type: Enhancement Most issues will probably ask for additions or changes. label Feb 28, 2023
@xm1k3 xm1k3 self-assigned this Feb 28, 2023
@xm1k3 xm1k3 linked an issue Feb 28, 2023 that may be closed by this pull request
Change rate limit logic and align the uncover flags the same way they are done on subfinder #164
Closed
xm1k3 added a commit that referenced this pull request Feb 28, 2023
@xm1k3
restored logic
d593f66 
- session and rate limit logic moved to #165
@xm1k3 xm1k3 force-pushed the issue-164-rate-limiting-logic branch from 5081b62 to 6570ce6 Compare March 1, 2023 19:25
@xm1k3 xm1k3 marked this pull request as ready for review March 1, 2023 21:10
tarunKoyalwar
tarunKoyalwar requested changes Mar 3, 2023
View reviewed changes
uncover/session.go Outdated Show resolved Hide resolved
uncover/session.go Show resolved Hide resolved
@tarunKoyalwar
Copy link
Member

tarunKoyalwar commented Mar 3, 2023 •
edited

@xm1k3
also current implemenation of uncover in nuclei is not abstract (ref: https://github.com/projectdiscovery/nuclei/blob/main/v2/pkg/protocols/common/uncover/uncover.go ) and is affected by minor changes . since this already is a breaking change we should design a minimalistic Uncover API that abstracts everythin g .

Refer tlsx.go which is a good example of how we can abstract uncover so that we don't have to update nuclei everytime we add/update uncover

@tarunKoyalwar
Copy link
Member

tarunKoyalwar commented Mar 3, 2023 •
edited by xm1k3

TODO

  • Create a follow up issue in nuclei and refactor uncover integration with new API

@xm1k3 xm1k3 requested a review from tarunKoyalwar March 3, 2023 15:44
@xm1k3
Copy link
Contributor Author

xm1k3 commented Mar 3, 2023

Proposal for Designing a Minimalistic Uncover API for Nuclei#168

Mzack9999
Mzack9999 requested changes Mar 3, 2023
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question about old delay behavior

runner/options.go Show resolved Hide resolved
@xm1k3 xm1k3 requested a review from Mzack9999 March 3, 2023 21:38
Mzack9999
Mzack9999 requested changes Mar 6, 2023
View reviewed changes
uncover/session.go Outdated Show resolved Hide resolved
@xm1k3 xm1k3 requested a review from Mzack9999 March 6, 2023 21:45
Mzack9999
Mzack9999 approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

tarunKoyalwar
tarunKoyalwar approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Mzack9999 Mzack9999 merged commit ebef080 into dev Mar 8, 2023
@Mzack9999 Mzack9999 deleted the issue-164-rate-limiting-logic branch March 8, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mzack9999 Mzack9999 Mzack9999 approved these changes

@tarunKoyalwar tarunKoyalwar tarunKoyalwar approved these changes

@ehsandeep ehsandeep Awaiting requested review from ehsandeep

Assignees

@xm1k3 xm1k3

Labels
Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change rate limit logic and align the uncover flags the same way they are done on subfinder
3 participants
@xm1k3 @tarunKoyalwar @Mzack9999