Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use standard config directories #302

Merged
merged 4 commits into from
Oct 12, 2023
Merged

use standard config directories #302

merged 4 commits into from
Oct 12, 2023

Conversation

tarunKoyalwar
Copy link
Member

@tarunKoyalwar tarunKoyalwar commented Oct 9, 2023 •
edited

Proposed Changes

  • context Use os-agnostic os.UserConfigDir func goflags#114
  • this PR updates default config directories used by uncover to standard ones
  • manually bumping goflags there by introducing auto-migration of old config files of uncover to new location
  • since path of config directory depends on setup / environment / distro it is printed with -version flag
$ ./uncover -version
[INF] Current Version: v1.0.6
[INF] Uncover ConfigDir: /Users/tarun/Library/Application Support/uncover

@tarunKoyalwar tarunKoyalwar self-assigned this Oct 9, 2023
Mzack9999
Mzack9999 approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - altough best practice, still $HOME is used by many other apps to store conf files

@tarunKoyalwar
Copy link
Member Author

yeah, i think only users who are running nuclei / tools on nixOS and aws lambda are facing this issue . where Home folder is read-only in both cases and also in sandbox env with custom configs

ref: projectdiscovery/nuclei#3576

@ehsandeep ehsandeep merged commit 900c9ea into dev Oct 12, 2023
8 checks passed
@ehsandeep ehsandeep deleted the std-config-dirs branch October 12, 2023 10:09
@chenrui333 chenrui333 mentioned this pull request Oct 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

@tarunKoyalwar tarunKoyalwar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tarunKoyalwar @ehsandeep @Mzack9999