Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update utils refactor and improvements #131

Merged
merged 9 commits into from
Apr 19, 2023
Merged

Conversation

tarunKoyalwar
Copy link
Member

@tarunKoyalwar tarunKoyalwar commented Apr 14, 2023

Proposed Changes

  • Tool Integrity is verified/validate when updating ( uses checksums.txt file from release if available)
  • Bug fix and refactor when toolName is different than repository Name (ex: projectdiscovery/interactsh & interactsh-client)
Old implementation used GHAssetName global variable which causes problems in tool integrations ( httpx + nuclei etc ) (this has not occured yet)
  • earlier v=v2.9.2 i.e version was not sent to pdtm endpoint during version check (@ehsandeep) . this issue is resolved by deprecating old callback with new one
GetVersionCheckCallback(toolName string) func() (string, error) <= deprecated
GetToolVersionCallback(toolName, version string) func() (string, error)  <= New callback

^ is not a breaking change and is deprecated properly . this will be picked up by golangci-lint gh actions downstream
Screenshot 2023-04-17 at 9 51 37 PM

  • If installed tool is from dev branch ex: v2.9.1-dev it is flaged as outdated and available for update if v2.9.1 is released
  • Adds support for downloading release asset (ex: nuclei-templates,fuzzing-templates etc) along with other minor improvements

@tarunKoyalwar tarunKoyalwar marked this pull request as draft April 14, 2023 18:51
@tarunKoyalwar tarunKoyalwar self-assigned this Apr 14, 2023
@tarunKoyalwar tarunKoyalwar marked this pull request as ready for review April 19, 2023 14:22
@tarunKoyalwar tarunKoyalwar changed the title update: refactor + checksum validation update utils refactor and improvements Apr 19, 2023
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! - suggesting minor optional change

update/gh.go Outdated Show resolved Hide resolved
@tarunKoyalwar tarunKoyalwar linked an issue Apr 19, 2023 that may be closed by this pull request
@Mzack9999 Mzack9999 merged commit 4878c80 into main Apr 19, 2023
7 checks passed
@Mzack9999 Mzack9999 deleted the update-utils-improvements branch April 19, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update utils improvements
2 participants