need to watch node status message #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
我理解 self mon 不应该去探测 engine 了 |
|
这个可以交给另外个 PR 啊 =.= 探测 engine 倒是也没问题 |
|
这样的话岂不是有2个东西决定着 node 的生死，没收敛啊- - |
|
我改我改 - - |
tonicmuroq
force-pushed
the
add-node-status-watcher
branch
from
63031dc
to
e1b64cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
由于是 agent 来处理 container 的 status, 那么如果 agent 挂了, 这之后挂掉的 container 就没办法被知道.
selfmon 只是监听 engine, 所以还会认为 container 健康.
那么需要处理 agent 挂了, engine 没挂的情况.
agent 那边会以 node 为维度刷心跳, selfmon 可以订阅 node 的事件, 这样 agent 挂了 selfmon 也可以知道, 设置一把 node 挂就行, 之后 agent 如果恢复了, container 的 status 由 agent 处理, selfmon 知道 agent 恢复之后设置成 node 恢复就行.