fix some small issues (#17)

* update workflow

* fix segfault in guest subcommand

* create all neccessary directories

* trivial

.github/workflows/dockerimage.yml

@@ -28,5 +28,5 @@ jobs:
           context: .
           push: true
           tags: |
-            projecteru2/yavirt:latest
-            projecteru2/yavirt:${{ github.ref_name }}
+            ${{ github.repository }}:latest
+            ${{ github.repository }}:${{ github.ref_name }}

.gitignore

@@ -3,3 +3,5 @@ cscope.*
 vendor/
 dist/
 yavirt
+
+.vscode

Makefile

@@ -25,7 +25,7 @@ setup:
 	go install github.com/vektra/mockery/v2@latest
 
 lint: format
-	PATH=${HOME}/go/bin:${PATH} golangci-lint run --skip-dirs-use-default --skip-dirs=thirdparty
+	golangci-lint run --skip-dirs-use-default --skip-dirs=thirdparty
 
 format: vet
 	gofmt -s -w $$(find . -iname '*.go' | grep -v -P '\./third_party|\./vendor/')

cmd/guest/guest.go

@@ -4,10 +4,13 @@ import (
 	"github.com/urfave/cli/v2"
 
 	"github.com/projecteru2/yavirt/cmd/run"
+	"github.com/projecteru2/yavirt/internal/models"
 )
 
 // Command .
 func Command() *cli.Command {
+	models.Setup()
+
 	return &cli.Command{
 		Name: "guest",
 		Subcommands: []*cli.Command{

configs/config.go

@@ -2,6 +2,7 @@ package configs
 
 import (
 	"crypto/tls"
+	"os"
 	"path/filepath"
 	"time"
 
@@ -181,15 +182,25 @@ func (c *Config) load(file string) error {
 		return errors.Trace(err)
 	}
 
-	c.loadVirtDirs()
+	if err := c.loadVirtDirs(); err != nil {
+		return err
+	}
 
 	return nil
 }
 
-func (c *Config) loadVirtDirs() {
+func (c *Config) loadVirtDirs() error {
 	c.VirtFlockDir = filepath.Join(c.VirtDir, "flock")
 	c.VirtTmplDir = filepath.Join(c.VirtDir, "template")
 	c.VirtSockDir = filepath.Join(c.VirtDir, "sock")
+	// ensure directories
+	for _, d := range []string{c.VirtFlockDir, c.VirtTmplDir, c.VirtSockDir} {
+		err := os.MkdirAll(d, 0755)
+		if err != nil && !os.IsExist(err) {
+			return err
+		}
+	}
+	return nil
 }
 
 // NewEtcdConfig .

internal/virt/virt.go

@@ -10,12 +10,6 @@ import (
 
 // Cleanup cleans flocks up.
 func Cleanup() error {
-	// ensure flock dir
-	err := os.Mkdir(configs.Conf.VirtFlockDir, 0755)
-	if err != nil && !os.IsExist(err) {
-		return err
-	}
-
 	files, err := os.ReadDir(configs.Conf.VirtFlockDir)
 	if err != nil {
 		return errors.Trace(err)

pkg/log/log.go

@@ -3,6 +3,7 @@ package log
 import (
 	"fmt"
 	"os"
+	"path/filepath"
 	"time"
 
 	"github.com/getsentry/sentry-go"
@@ -46,8 +47,13 @@ func setupOutput(file string) error {
 	if len(file) < 1 {
 		return nil
 	}
-
-	var f, err = os.OpenFile(file, os.O_APPEND|os.O_CREATE|os.O_RDWR, os.ModePerm)
+	// make dir if necessary
+	err := os.MkdirAll(filepath.Dir(file), 0755)
+	if err != nil && !os.IsExist(err) {
+		return err
+	}
+	// open file for logger
+	f, err := os.OpenFile(file, os.O_APPEND|os.O_CREATE|os.O_RDWR, os.ModePerm)
 	if err != nil {
 		return errors.Trace(err)
 	}