implements GetGuestIDList svc

Makefile

@@ -23,8 +23,6 @@ build-ctl:
 setup:
 	go install github.com/golangci/golangci-lint/cmd/golangci-lint@latest
 	go install github.com/vektra/mockery/v2@latest
-	go install google.golang.org/protobuf/cmd/protoc-gen-go@v1.28
-	go install google.golang.org/grpc/cmd/protoc-gen-go-grpc@v1.2
 
 lint: format
 	PATH=${HOME}/go/bin:${PATH} golangci-lint run --skip-dirs-use-default --skip-dirs=thirdparty

internal/server/service.go

@@ -163,6 +163,17 @@ func (svc *Service) GetGuest(ctx virt.Context, id string) (*types.Guest, error)
 	return convGuestResp(vg.Guest), nil
 }
 
+// GetGuestIDList .
+func (svc *Service) GetGuestIDList(ctx virt.Context) ([]string, error) {
+	ids, err := svc.guest.ListLocalIDs(ctx)
+	if err != nil {
+		log.ErrorStack(err)
+		metrics.IncrError()
+		return nil, err
+	}
+	return ids, err
+}
+
 // GetGuestUUID .
 func (svc *Service) GetGuestUUID(ctx virt.Context, id string) (string, error) {
 	uuid, err := svc.guest.LoadUUID(ctx, id)

internal/server/service_test.go

@@ -51,6 +51,15 @@ func TestGetGuest(t *testing.T) {
 	assert.NilErr(t, err)
 }
 
+func TestGetGuestIDList(t *testing.T) {
+	localIDs := []string{"ya0", "ya1", "ya2"}
+	svc := testService(t)
+	svc.guest.(*managerocks.Manageable).On("ListLocalIDs", mock.Anything, mock.Anything).Return(localIDs, nil).Once()
+	ids, err := svc.GetGuestIDList(testVirtContext(t))
+	assert.NilErr(t, err)
+	assert.Equal(t, []string{"ya0", "ya1", "ya2"}, ids)
+}
+
 func TestGetGuestUUID(t *testing.T) {
 	svc := testService(t)
 	svc.guest.(*managerocks.Manageable).On("LoadUUID", mock.Anything, mock.Anything).Return("uuid", nil)

internal/virt/guest/bot.go

@@ -64,7 +64,7 @@ type bot struct {
 }
 
 func newVirtGuest(guest *Guest) (Bot, error) {
-	virt, err := libvirt.Connect("qemu:///system")
+	virt, err := connectSystemLibvirt()
 	if err != nil {
 		return nil, errors.Trace(err)
 	}
@@ -81,6 +81,10 @@ func newVirtGuest(guest *Guest) (Bot, error) {
 	return vg, nil
 }
 
+func connectSystemLibvirt() (libvirt.Libvirt, error) {
+	return libvirt.Connect("qemu:///system")
+}
+
 func newVolume(volmod *models.Volume) volume.Virt {
 	return volume.New(volmod)
 }

internal/virt/guest/guest.go

@@ -36,6 +36,22 @@ func New(ctx virt.Context, g *models.Guest) *Guest {
 	}
 }
 
+// ListLocalIDs lists all local guest domain names.
+func ListLocalIDs(virt.Context) ([]string, error) {
+	virt, err := connectSystemLibvirt()
+	if err != nil {
+		return nil, errors.Trace(err)
+	}
+
+	defer func() {
+		if _, ce := virt.Close(); ce != nil {
+			log.ErrorStack(ce)
+		}
+	}()
+
+	return virt.ListDomainsNames()
+}
+
 // Load .
 func (g *Guest) Load() error {
 	host, err := models.LoadHost(g.HostName)

internal/virt/guest/manager/manager.go

@@ -67,6 +67,7 @@ type Controllable interface {
 type Loadable interface {
 	Load(ctx virt.Context, id string) (*guest.Guest, error)
 	LoadUUID(ctx virt.Context, id string) (string, error)
+	ListLocalIDs(virt.Context) ([]string, error)
 }
 
 var imageMutex sync.Mutex
@@ -577,6 +578,11 @@ func (m Manager) doCtrl(ctx virt.Context, id string, op op, fn doCtrlFunc, rollb
 	return m.do(ctx, id, op, do, rollback)
 }
 
+// ListLocals lists all local guests.
+func (m Manager) ListLocalIDs(ctx virt.Context) ([]string, error) {
+	return guest.ListLocalIDs(ctx)
+}
+
 // LoadUUID read a guest's UUID.
 func (m Manager) LoadUUID(ctx virt.Context, id string) (string, error) {
 	g, err := m.Load(ctx, id)

pkg/libvirt/libvirt.go

@@ -26,11 +26,6 @@ func Connect(uri string) (l *Libvirtee, err error) {
 	return
 }
 
-// ListAllDomains lists all domains regardless the state.
-func (l *Libvirtee) ListAllDomains() ([]libvirtgo.Domain, error) {
-	return l.Connect.ListAllDomains(ListAllDomainFlags)
-}
-
 // DefineDomain defines a new domain.
 func (l *Libvirtee) DefineDomain(xml string) (Domain, error) {
 	raw, err := l.Connect.DomainDefineXML(xml)
@@ -54,7 +49,7 @@ func (l *Libvirtee) LookupDomain(name string) (Domain, error) {
 
 // ListDomainsNames lists all domains' name.
 func (l *Libvirtee) ListDomainsNames() ([]string, error) {
-	raw, err := l.Connect.ListAllDomains(ListAllDomainFlags)
+	raw, err := l.ListAllDomains()
 	if err != nil {
 		return nil, errors.Trace(err)
 	}
@@ -68,3 +63,8 @@ func (l *Libvirtee) ListDomainsNames() ([]string, error) {
 
 	return names, nil
 }
+
+// ListAllDomains lists all domains regardless the state.
+func (l *Libvirtee) ListAllDomains() ([]libvirtgo.Domain, error) {
+	return l.Connect.ListAllDomains(ListAllDomainFlags)
+}