Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cgo libvirt migrate to pure go libvirt #20

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

cgo libvirt migrate to pure go libvirt #20

wants to merge 10 commits into from

Conversation

nyl1001
Copy link

@nyl1001 nyl1001 commented Oct 25, 2023

No description provided.

@nyl1001
Copy link
Author

nyl1001 commented Oct 25, 2023

不再使用cgo libvirt的原因，一来cgo libvirt不方便调试且难以维护，二来c代码申请的内存和变量需要手动释放，容易产生内存泄露。

anrs
anrs reviewed Oct 26, 2023
View reviewed changes
pkg/libvirt/console.go Outdated Show resolved Hide resolved
anrs
anrs reviewed Oct 26, 2023
View reviewed changes
pkg/libvirt/console.go Outdated Show resolved Hide resolved
anrs
anrs reviewed Oct 26, 2023
View reviewed changes
pkg/libvirt/console.go Outdated Show resolved Hide resolved
anrs
anrs reviewed Oct 26, 2023
View reviewed changes
pkg/libvirt/console.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anrs anrs anrs left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nyl1001 @anrs