Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Score #18

Open
supergoudvisje opened this issue Oct 4, 2016 · 2 comments
Open

Score #18

supergoudvisje opened this issue Oct 4, 2016 · 2 comments

Comments

@supergoudvisje
Copy link

The score doesn't seem to be right!
For 'Panels-Identify' I made 13 actions, 12 were right, 1 wrong and my score is 8%.

@frncesc
Copy link
Member

frncesc commented Oct 4, 2016

Well... how many cells have this activity?

The algorithm used to calculate the activity final score is:
https://github.com/projectestac/jclic/blob/master/src/core/edu/xtec/jclic/report/ActivityReg.java#L160

As you can see, the algorithm takes in account three variables:

  • numActions: The number of actions done
  • score: The number of right actions
  • minActions: The number of actions needed to solve the activity (in this case, the number of cells to be identified)

Let's suppose an identification activity where 138 cells must be identified (a time wasting, tedious activity, but is a possibility). The minimum number of actions needed to solve the activity (minActions) is 138.

You made 13 actions (numActions), 12 of which where right (score). You don't have solved the activity, so solved is false. Then, the formula used to calculate the final activity score is:

100 * (12 * 12 ) / (13 * 138)

This gives a final result of 8,0267, rounded to 8 over 100.

@frncesc
Copy link
Member

frncesc commented Oct 5, 2016

Update: I have found an error in JClic.js that caused an incorrect calculation of the minActions member of the equation.

The bug is fixed in: projectestac/jclic.js@033c56d

A new version of JClic.js (0.1.37) will be published soon, having this issue fixed.

Note that this bug only affects JClic.js (the HTML5 player). The JClic Java applet and player should work fine.

Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants