Add CachedIterable.from #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It behaves similar to the constructor. It can also detect instances of CachedSyncIterable and CachedAsyncIterable passed as the argument and if the argument's class matches the class from() was called on, it returns the argument unmodified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The static method
from()may be used to create newCachedIterableinstances from other iterables (which is the same as using the constructor) or to re-use existing ones. When an existing instance ofCachedIterableis passed,from()simply returns it, preserving its cached state.The use-case is
fluent-reactand projectfluent/fluent.js#100. TheLocalizationclass by default wraps the iterable of contexts it receives in a CachedAsyncIterable. At the same time, the user offluent-reactmight want to prefetch some contexts from that iterable before handing it off toLocalization.Fixes #2.