Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement From<&String> for FluentValue #251

Merged
merged 1 commit into from Feb 28, 2022
Merged

Implement From<&String> for FluentValue #251

merged 1 commit into from Feb 28, 2022

Conversation

LegionMammal978
Copy link
Contributor

This is useful for macros such as i18-embed-fl's fl! to accept String values by reference without requiring as_str or slice syntax. It directly corresponds to impl<'a> From<&'a String> for Cow<'a, str>.

@zbraniecki
Copy link
Collaborator

thank you! That looks good!

@zbraniecki zbraniecki merged commit 7ec02bf into projectfluent:master Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbraniecki zbraniecki zbraniecki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LegionMammal978 @zbraniecki