Add cargo-make with the ability to run code coverage locally #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds cargo-make as a dependency for the project, and allows for running commands locally from a central location.
gregtatum
force-pushed
the
cargo-make
branch
from
9c63e80
to
794f345
Compare
This is from ignoring the |
nordzilla
approved these changes
Nov 16, 2022
There was a problem hiding this comment.
I've never set up a cargo-make ecosystem myself, so I'm not familiar with specific styles/syntax/best practices for the purpose of review, but everything I read here looks reasonable to me and appears to be running the coverage, and it looks like the CI is working correctly for PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm opening as a draft to check that CI is running before requesting review.
Edit: It is generating the code coverage report: https://coveralls.io/builds/54294084