Plural rule handling from intl_pluralrules #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbraniecki
approved these changes
Jul 31, 2018
zbraniecki
reviewed
Jul 31, 2018
|
|
||
| let locale = supported[0].to_owned(); | ||
|
|
||
| let pr = IntlPluralRules::create(&locale, PluralRuleType::CARDINAL).unwrap(); |
There was a problem hiding this comment.
Turning a string slice into an owner String, just to pass a reference (slice) to it in the next line doesn't make much sense ;)
Next time:
let pr = IntlPluralRules::create(supported[0], ...);
bjorn3
reviewed
Jul 31, 2018
| @@ -22,3 +22,4 @@ fluent-locale = "0.3.1" | |||
| fluent-syntax = "0.1.0" | |||
| failure = "0.1.1" | |||
| failure_derive = "0.1.1" | |||
| intl_pluralrules = "0.8.1" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove mock implementation for plural rules and integrate intl_pluralrules crate.