-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests failing, also not all tests are running #92
Comments
The
when i remove it I see:
@hkasemir - can you investigate which tests are failing and why? I suspect something is off with your node environment and its different than the one we have. It may be that you need Intl API, or it may be that we need to handle more variants of Node+Intl combinations, but I'd like to start with identifying tests and their failures. |
Sorry about the regression introduced in #81. I use |
There's also https://www.npmjs.com/package/eslint-plugin-mocha which has more configuration options. |
I opened #94 to add a linting rule forbidding I have the same output as @zbraniecki before and after fixing that rogue |
using node v6.11.2 and npm 5.4.1 fresh clone of the repo: using node v8.9.1, seems all tests are passing 🤔 could be a good idea to define which version of node is required in the readme under instructions for local dev. Glad that was an easy fix. I did take the liberty of checking #93 to make sure it was not fixed by node version, but it is still an issue. |
I found out why the tests fail. Node 6.x doesn't support fluent.js/fluent/src/builtins.js Line 29 in da0a580
Given that node 8.x has already become the active LTS version I think it makes sense to explicitly drop support for 6.x (and 7.x too, even though the tests actually pass on 7.x). |
Following instructions to set up and test the fluent packages results in tests failing
also, this line is preventing some tests from running: https://github.com/projectfluent/fluent.js/blob/master/fluent/test/functions_builtin_test.js#L86
with that
.only
included, one test fails, by removing it, 6 tests fail.The text was updated successfully, but these errors were encountered: