Catch errors thrown by Intl formatters #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Intl formatters may throw errors when constructed (if unrecognized options are passed) or in format() if the formatted value is not supported. This is a simple fix which simply catches those errors. The real fix should report them, for instance into env.errors, but it's not clear to me right now how to do this right.
stasm
force-pushed
the
keyargs-hotfix
branch
2 times, most recently
from
2d9f92e
to
72d4a2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intl formatters may throw errors when constructed (if unrecognized
options are passed) or in format() if the formatted value is not
supported.
This is a simple fix which simply catches those errors. The real fix
should report them, for instance into env.errors, but it's not clear to
me right now how to do this right.