Add Headers parsing function #38
Conversation
fluent-langneg/src/headers.js
Outdated
| if (typeof string !== 'string') throw new TypeError('Argument must be a string'); | ||
| const tokens = string.split(',').map(t => t.trim()); | ||
| return tokens.filter(t => t !== '').map(t => { | ||
| return t.split(';')[0]; |
There was a problem hiding this comment.
This doesn't take into effect the q-value nor the specificity of the locale tag. Are we fine with this?
There was a problem hiding this comment.
yes, this is on purpose. We don't act upon the q-value at all. The order is the only indication for our fallback, there's no increase/decrease in fallback based on the q-value.
There was a problem hiding this comment.
Do you plan to extend this in the future? The RFC says the q-values are in fact important.
fluent-langneg/src/headers.js
Outdated
| @@ -0,0 +1,8 @@ | |||
|
|
|||
| export default function parseAcceptedLanguagesHeaderIntoArray(string = '') { | |||
There was a problem hiding this comment.
Rename this simply to acceptedLanguages please.
fluent-langneg/src/headers.js
Outdated
| @@ -0,0 +1,8 @@ | |||
|
|
|||
| export default function parseAcceptedLanguagesHeaderIntoArray(string = '') { | |||
| if (typeof string !== 'string') throw new TypeError('Argument must be a string'); | |||
There was a problem hiding this comment.
Please break this into an if .. and a {} block.
|
And maybe rename the file to |
|
Applied feedback |
| @@ -0,0 +1,10 @@ | |||
|
|
|||
| export default function aceptedLanguages(string = '') { | |||
| const tokens = string.split(',').map(t => t.trim()); | ||
| return tokens.filter(t => t !== '').map(t => { | ||
| return t.split(';')[0]; | ||
| }); |
There was a problem hiding this comment.
This is a nit, but there's no need to use {} here and an explicit return. Can you change this to a one-liner arrow function?
Fixes #34