Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add per locale Intl memoizer #504

Merged
merged 2 commits into from
Oct 25, 2021
Merged

Conversation

Demivan
Copy link
Contributor

@Demivan Demivan commented Jul 17, 2020

This allows multiple bundles with same locale to share Intl cache

@Demivan
Copy link
Contributor Author

Demivan commented May 28, 2021

Sorry for pinging. Anything need to be changed for this to be merged?
I can see that this pull requests fixes same issue #254 tries to fix. If that is preferred API I can change this pull request to match #254 API.

@zbraniecki
Copy link
Collaborator

@Demivan we're currently focused on finishing the Rust translation of this library and those PRs for JS are a bit on a backburner. I'm sorry for it. Within a month we'll start looking again at them and hope to start addressing all the backlog here.

In the meantime, if you have a suggestion wrt. the WeakMap, feel free to take over the PR :)

@Demivan
Copy link
Contributor Author

Demivan commented Aug 4, 2021

Hi.
Any chance this gets merged before next release? Anything need to be changed? I have rebased this PR and fixed conflicts.
Is there planned date for next release?

Copy link
Member

@eemeli eemeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay; finally got around to looking at this. And it's good! I think it might make sense to eventually separate the memoiser even further form the bundle, as I at least find it a little surprising how the class, locale arg, and options arg are now all handled in very different parts of the API. But that'd be a larger change than this, which makes sense just by itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants