Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make pauseObserving and resumeObserving public #623

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Make pauseObserving and resumeObserving public #623

merged 2 commits into from
Feb 28, 2024

Conversation

calixteman
Copy link
Contributor

This is consistent with mozilla-central.

@calixteman
Make pauseObserving and resumeObserving public
fdabc5c 
This is consistent with mozilla-central.
eemeli
eemeli approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@eemeli eemeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the minimum supported version updates in #627, the breaking changes here won't add a new semver-major update requirement. (well, semver-minor given that we're still 0.x)

@eemeli eemeli merged commit c5c44b8 into projectfluent:main Feb 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eemeli eemeli eemeli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@calixteman @eemeli