Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tag sigil #59

Closed
stasm opened this issue Oct 23, 2017 · 4 comments
Closed

Change tag sigil #59

stasm opened this issue Oct 23, 2017 · 4 comments
Milestone

Comments

@stasm
Copy link
Contributor

stasm commented Oct 23, 2017

Goal

Allow to use # for comments in #58.

Description

We chose # for tags in #7 and actually had to change the comment sigil from # to // in #28. If the Comments Levels (#58) gets enough support I'd like to reclaim # for comments and find a new sigil for tags.

I propose + which was also my second proposal in #7.

Example

brand-name = Firefox
    +masculine

updated =
    { brand-name ->
        [masculine] { brand-name } został zaktualizowany.
        [feminine] { brand-name } została zaktualizowana.
       *[other] Program { brand-name } został zaktualizowany.
    }
@stasm stasm mentioned this issue Oct 23, 2017
3 tasks
@stasm
Copy link
Contributor Author

stasm commented Oct 23, 2017

AFAIK, there are no uses of tags in Mozilla projects right now.

@zbraniecki
Copy link
Collaborator

Is it a temporary measure until semantic comments, or a final proposal and you don't like the idea of using semantic comments for that?

@stasm
Copy link
Contributor Author

stasm commented Oct 24, 2017

I think we should discuss semantic comments in #16. My understanding of the scope of semantic comments is that they would be a place to put extra data available to tools rather than the runtime. In fact they wouldn't be parsed on runtime at all. This would make it impossible to use them for tags. (Let's continue in #16.)

@stasm stasm added this to the Syntax 0.5 milestone Nov 2, 2017
@stasm stasm mentioned this issue Nov 10, 2017
3 tasks
@stasm stasm added the syntax label Nov 10, 2017
@stasm
Copy link
Contributor Author

stasm commented Nov 30, 2017

We decided to replace tags with attributes defined on private messages. See #67 for discussion and #69 for implementation.

@stasm stasm closed this as completed Nov 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants