Revert #74 - Syntax sugar for block expression values #81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The block expression syntax sugar discussed in #42 and introduced in #74 allowed the closing brace of a block expression which is the only placeable in the pattern to be on the first column of the line, without indentation. Requiring the closing
}
to be indented had been reported as a papercut.The above syntax is desired and more intuitive and we'll try to make it possible in the future along with other changes relaxing the indentation requirement. For now, the block expression sugar can be surprising and it creates a false expectation that the closing
}
doesn't need to be indented.It also creates a refactoring hazard: factoring a common part of the translation out of a block expression results in a syntax error:
For the time being, the recommended formatting of block expression is to indent the entire body of the message:
new-messages = { $num -> [one] New message *[other] New messages }