Fix large PLINK file ingest #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karen Feng <karen.feng@databricks.com>
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
==========================================
+ Coverage 94.77% 94.79% +0.02%
==========================================
Files 82 82
Lines 3999 3999
Branches 382 380 -2
==========================================
+ Hits 3790 3791 +1
+ Misses 209 208 -1
Continue to review full report at Codecov.
|
karenfeng
changed the title
kianfar77
approved these changes
Jan 21, 2020
bboutkov
pushed a commit
to bboutkov/glow
that referenced
this pull request
Jan 22, 2020
Signed-off-by: Karen Feng <karen.feng@databricks.com>
henrydavidge
pushed a commit
to henrydavidge/glow
that referenced
this pull request
Jun 22, 2020
Signed-off-by: Karen Feng <karen.feng@databricks.com> Signed-off-by: Henry Davidge <hhd@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Calculates the byte location for a variant in a (PLINK) BED file as a
Longto avoid integer overflow.Addresses #133.
How is this patch tested?
Successfully ran through the workflow described in the aforementioned issue.