Allow 0 partitions in big VCF/BGEN writers and pipe transformer #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karen Feng <karen.feng@databricks.com>
Signed-off-by: Karen Feng <karen.feng@databricks.com>
Codecov Report
@@ Coverage Diff @@
## master #164 +/- ##
==========================================
+ Coverage 92.06% 92.14% +0.07%
==========================================
Files 86 86
Lines 4123 4135 +12
Branches 381 389 +8
==========================================
+ Hits 3796 3810 +14
+ Misses 327 325 -2
Continue to review full report at Codecov.
|
Signed-off-by: Karen Feng <karen.feng@databricks.com>
karenfeng
changed the title
karenfeng
changed the title
fnothaft
approved these changes
Feb 24, 2020
Signed-off-by: Karen Feng <karen.feng@databricks.com>
kianfar77
pushed a commit
to kianfar77/glow
that referenced
this pull request
Feb 28, 2020
…ectglow#164) * Check for 0 partitions in big BGEN writer and piper Signed-off-by: Karen Feng <karen.feng@databricks.com> * Scalastyle Signed-off-by: Karen Feng <karen.feng@databricks.com> * Testing Signed-off-by: Karen Feng <karen.feng@databricks.com> * Replace empty, 0-partition RDD with empty, 1-partition RDD Signed-off-by: Karen Feng <karen.feng@databricks.com> * Clean up Signed-off-by: Karen Feng <karen.feng@databricks.com> * Undo cosmetic changes Signed-off-by: Karen Feng <karen.feng@databricks.com> Signed-off-by: kianfar77 <kiavash.kianfar@databricks.com>
henrydavidge
pushed a commit
to henrydavidge/glow
that referenced
this pull request
Jun 22, 2020
…ectglow#164) * Check for 0 partitions in big BGEN writer and piper Signed-off-by: Karen Feng <karen.feng@databricks.com> * Scalastyle Signed-off-by: Karen Feng <karen.feng@databricks.com> * Testing Signed-off-by: Karen Feng <karen.feng@databricks.com> * Replace empty, 0-partition RDD with empty, 1-partition RDD Signed-off-by: Karen Feng <karen.feng@databricks.com> * Clean up Signed-off-by: Karen Feng <karen.feng@databricks.com> * Undo cosmetic changes Signed-off-by: Karen Feng <karen.feng@databricks.com> Signed-off-by: Henry Davidge <hhd@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
We currently have inconsistent behavior between the following tools that act on RDD partitions in the case that there are 0 partitions:
Now, we replace the underlying 0-row, 0-partition RDD with a 0-row, 1-partition RDD. This allows users to write big VCF/BGENs or pipe with the header alone. This will un-break our tests on SPARK-30780, which causes empty DataFrames to (usually) be backed by an empty RDD with 0 partitions.
How is this patch tested?