Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define output_delta in 0_setup_constants_glow.py #483

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

@cameronraysmith cameronraysmith changed the title define output_delta define output_delta in 0_setup_constants_glow.py Feb 11, 2022
@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #483 (57e83c0) into master (77827ba) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #483   +/-   ##
=======================================
  Coverage   93.66%   93.66%           
=======================================
  Files          95       95           
  Lines        4875     4875           
  Branches      457      457           
=======================================
  Hits         4566     4566           
  Misses        309      309           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77827ba...57e83c0. Read the comment docs.

@williambrandler
Copy link
Contributor

williambrandler commented Feb 15, 2022

hey Cameron, thank you for spotting this! Will merge this in, in order to make the tests pass:

Please can you also drop in an html version of the notebook following this here:

https://glow.readthedocs.io/en/latest/contributing.html#modify-or-add-notebooks

And then convert to python following the script.

Also please sign off commits:

git commit -m "initial commit" --signoff

The easiest way to rectify signoffs is to close the PR and reopen. Or follow here:
https://github.com/projectglow/glow/pull/483/checks?check_run_id=5160914682

@cameronraysmith
Copy link
Contributor Author

Hello @williambrandler, those issues have now been addressed. Many thanks.

@williambrandler
Copy link
Contributor

Thanks @cameronraysmith!

@williambrandler williambrandler merged commit f098989 into projectglow:master Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants