Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal attempt to support Spark 3.3 by adding shims for CSVOptions methods #524

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

srowen
Copy link
Contributor

@srowen srowen commented Jan 19, 2023

What changes are proposed in this pull request?

This change minimally enables compiling and running on Spark 3.3, by shimming over one new difference - date/time format fields in CSVOptions changed.

How is this patch tested?

  • Unit tests
  • Integration tests
  • Manual tests

Note that there appear to be existing test failures (?)
I also don't know if this actually works on Spark 3.1/2.4, but, those seem unsupported?

…ethods

Signed-off-by: Sean Owen <srowen@gmail.com>
@rlgarris
Copy link
Collaborator

Pushing this through and will fix tests later. Spark 3.X support

@rlgarris rlgarris closed this Jan 23, 2023
@rlgarris rlgarris reopened this Jan 23, 2023
Copy link
Collaborator

@rlgarris rlgarris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding changes for Spark 3.3 support

Copy link
Collaborator

@rlgarris rlgarris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added changes to support Spark 3.2.1

@rlgarris
Copy link
Collaborator

Pushing through these changes.

@rlgarris rlgarris closed this Jan 24, 2023
@rlgarris rlgarris reopened this Jan 24, 2023
@rlgarris rlgarris merged commit 27d0d0a into projectglow:master Jan 24, 2023
@rlgarris
Copy link
Collaborator

Done.

@srowen srowen deleted the Spark33 branch January 24, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants