Support for GNOME 45, drop support for previous GNOME versions #364
Conversation
Signed-off-by: Martin Wilck <mwilck@suse.com>
https://gjs.guide/extensions/upgrading/gnome-shell-45.html Signed-off-by: Martin Wilck <mwilck@suse.com>
https://gjs.guide/extensions/upgrading/gnome-shell-45.html#extension-js Signed-off-by: Martin Wilck <mwilck@suse.com>
I used check buttons for the settings. Adw.ComboRow might have been more suitable, but I couldn't find an example how to set it up. The code here was copied from GNOME's window-list extension and adapted to hamster. Signed-off-by: Martin Wilck <mwilck@suse.com>
This implies that support for all previous GNOME versions is dropped. (https://gjs.guide/extensions/upgrading/gnome-shell-45.html#shell-version) Signed-off-by: Martin Wilck <mwilck@suse.com>
Signed-off-by: Martin Wilck <mwilck@suse.com>
"global" isn't generally available any more. Signed-off-by: Martin Wilck <mwilck@suse.com>
| console.log("HotkeyRow: good hotkey value ", hotkeys); | ||
| this.current = mappings; | ||
| settings.set_strv(bind, this.current); | ||
| } else { | ||
| console.log("invalid hotkey value ", hotkeys); | ||
| this.set_text(this.current.join(",")); |
There was a problem hiding this comment.
Doesn't seem to be properly indented.
| action_name: 'hamster.panel-placement', | ||
| action_target: new GLib.Variant('i', p), | ||
| }); | ||
| const row = new Adw.ActionRow({ | ||
| activatable_widget: btn, | ||
| title, |
There was a problem hiding this comment.
Indentation problem here too. and some other locations below, which I won't comment :P
|
Tested here, working great for me! |
|
Hi, after updating to |
That sounds more like an issue with hamster itself. Did you perhaps update not only the GNOME extension, but also hamster? Can you run "hamster" from the command line? Does the extension work after you do? |
|
The hamster processess are running - after running hamster from command line there is no difference. I will try to test on fresh user profile. |
* *Box add() -> add_child() * Actor add_actor() -> add_child() * Actor remove_actor() -> remove_child()
|
Can confirm, everything works properly. Fedora39, Gnome 45.5, Hamster master branch (81be67e08a6c2a69f2f042df5459dba886cbd7de). |
Support Gnome Shell 46
|
As GNOME 45 is out for 6 months now, I've merged this into the |
This PR fixes #362. When it is merged, we will have to rework our sticky issue #327.