Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My subjective concerns about the hamster 3.0 release #579

Open
mwilck opened this issue Mar 6, 2020 · 3 comments
Open

My subjective concerns about the hamster 3.0 release #579

mwilck opened this issue Mar 6, 2020 · 3 comments

Comments

@mwilck
Copy link
Contributor

mwilck commented Mar 6, 2020

I fear this post will earn me thumbs-down emojis, but I think I need to discuss this once more. There's little new content here, most has been said elswhere already; I'm just trying to summarize. Links are provided.

I've been using hamster 3.0-x for a few weeks, since the beta release. The other day, I made a mistake while updating my system, and inadvertently downgraded hamster to openSUSE's official 2.2.2 release. After a few hours, I realized that I enjoyed using hamster more than I did with 3.0. Here are the reasons:

  1. I totally miss the idle detection under GNOME in 3.0 (3.0-rc1: hamster ignores screen lock events #568). I seem to be simply unable to remember stopping the current activity manually before I leave or lock the screen. When I get back, I have to start guessing when might have left. This feature, along with other desktop integration features, has been deliberately removed (Move idle, external, and similar features elsewhere #493, Remove external stuff #494). @ederag said that the functionality could be reinstated by creating another service, and that's true. But doing that is not a one-day task. For the time being, this feature will be missing from hamster. This affects only GNOME users, because the feature never worked in other environments anyway.

  2. With 2.2.2, when I click the "edit" button in the GNOME extension, the hamster "edit activity" window appears immediately, as if the extension and the hamster were the same application. With 3.0, the reaction time is significantly more sluggish. I think the main reason is that in 3.0, the original implementation of the hamster-windows-service DBus API has been replaced (Restore edit, remove dialogs #549) by wrappers, which fork() and exec() the hamster command. That's necessarily slower than an already running background application simply popping up a dialog. This is not a fatal regression, but it does affect how working with the UI "feels", in particular if the GNOME extension is involved. I haven't seen a convincing argument why this code needed to be removed. @ederag has called it technical debt, but don't understand why - IMO, that code was no worse than anything else in hamster.

  3. A new org.gnome.Hamster.GUI DBus API has been added, but it's not fully functional and behaves strangely ('org.gnome.Hamster.GUI' - strange semantics of window pop-up and persistence #563). IIUC, the intention is to use it as a replacement for the windows service some day, but not yet:

    but that is still experimental, the actions API is subject to change.
    @ederag argued that this is the new gnome way. It's true that GNOME advertises the GApplication API, but I haven't seen evidence yet that this means other APIs are now deprecated, or need to be replaced short term. I am a little wary of exposing a DBus API in an official release which is considered experimental by the developers.

  4. @ederag has invested lots of work into the multi-input "edit activity" dialog (Separate edit fields #461 and related PRs/issues). I've had a few discussions with him and others about this, but it was only after I had downgraded to hamster 2.2.2 that I realized how much I prefer the single-input KISS-style pop-up of the old version. Although the new multi-input dialog is well laid-out, the sheer number of inputs feels distracting and confusing to me. 95% of the time, I only open this dialog to fix the start time of the current activity.

All this is totally subjective and personal. Going back to 2.2.x is not an option. Some changes in 3.0, like the waf update and the move from gconf to gsettings, are mandatory, and, thanks to @ederag's work, there are lots of bug fixes in the 3.0 release which nobody wants to loose.

I do appreciate @ederag's work very much, and I definitely don't want to scare anybody away from using or trying hamster 3.0. Perhaps it's really just me who prefers the "feel" of the previous version. I just want to encourage a discussion - perhaps we can find a remedy for the issues raised. If everyone else thinks that I'm on the wrong track, just close this.

@mwilck
Copy link
Contributor Author

mwilck commented Mar 11, 2020

@GeraldJansen, I got a response from you for this issue via email, but I am unable to see it here on github. So I can't respond, either.

@GeraldJansen
Copy link
Contributor

I deleted my message here when I decided to leave the project because I chose not to engage in further negative discussion.

@mwilck
Copy link
Contributor Author

mwilck commented Mar 11, 2020

Fair enough. Thanks for the clarification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants