Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix examples running on LAN #290

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Fix examples running on LAN #290

merged 1 commit into from
Jun 13, 2024

Conversation

Shatur
Copy link
Contributor

@Shatur Shatur commented Jun 12, 2024

  • We should bind "0.0.0.0" for UdpSocket.
  • public_addresses is not needed with ServerAuthentication::Unsecure.

We should bind "0.0.0.0" for UdpSocket.
@Shatur Shatur requested a review from UkoeHB June 12, 2024 23:42
@Shatur Shatur marked this pull request as ready for review June 12, 2024 23:42
@Shatur Shatur enabled auto-merge (squash) June 12, 2024 23:45
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.81%. Comparing base (434837b) to head (003c265).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #290   +/-   ##
=======================================
  Coverage   90.81%   90.81%           
=======================================
  Files          38       38           
  Lines        2341     2341           
=======================================
  Hits         2126     2126           
  Misses        215      215           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Shatur Shatur merged commit b3f1505 into master Jun 13, 2024
5 checks passed
@Shatur Shatur deleted the fix-examples-lan branch June 13, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants