Fixing deprecated tests, non-quiet Ladle causing test failures #5
Conversation
escowles
commented
Sep 1, 2015
escowles
commented
- Using expect() syntax
- Adding "quiet" parameter to Ladle config to fix test failures
| end | ||
|
|
||
| it "should return a list of groups owned by quentin" do | ||
| attrs = { | ||
| :cn => 'TR', | ||
| :cn => 'TrueRomance', |
There was a problem hiding this comment.
This line fails for me unless I make that change: https://github.com/escowles/hydra-ldap/blob/fix-tests/spec/integration/ldap_spec.rb#L87
As-is, I get ["PulpFiction',"TR"] instead of the expected ["PulpFiction","TrueRomance"]
There was a problem hiding this comment.
Weird. How did that ever pass? Well, no matter, 👍 to this change!
There was a problem hiding this comment.
I read the test a couple of times wondering if I was missing something -- maybe it never passed? On that score, I can add a .travis.yml file as long as I'm adding a new commit to fix your other comment.
|
I haven't been able to reproduce the Travis error on my machine or on fresh Ubuntu VMs (tried 12.04 and 14.04). |
|
You've got me, @escowles, but I'm inclined to |
(thinking that the error is something Travis-y and not worth tracking down at the moment)
Fixing deprecated tests, non-quiet Ladle causing test failures
