New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the Get* services #110

Closed

jcoyne opened this issue May 20, 2015 · 1 comment

Member

jcoyne commented May 20, 2015

The models already provide this service. We're wandering into the Anemic Domain Model and Poltergeist antipatterns.

I propose we remove:

lib/hydra/pcdm/services/collection/get_collections.rb
lib/hydra/pcdm/services/collection/get_objects.rb
lib/hydra/pcdm/services/collection/get_related_objects.rb
lib/hydra/pcdm/services/object/get_objects.rb
lib/hydra/pcdm/services/object/get_related_objects.rb

@elrayle do you agree?

The text was updated successfully, but these errors were encountered:

mjgiarlo added summer-2015 and removed summer-2015 labels

Contributor

tpendragon commented Jul 20, 2015

@jcoyne These are now deprecated, can we close it?

jrgriffiniii closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment