New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As an Admin Set Manager, I should be able to view and act upon works in Admin Sets I manage in a new "Managed Works" tab #965
Comments
Comment by jcoyne @hannahfrost this seems just like #855, but "as an admin set manager" instead of "as a repository administrator". Is that correct? |
Comment by jcoyne @hannahfrost is there some reason this is in hyku and not hyrax? Additionally, should an "admin set manager" get the "All works" tab on this page? samvera/hyku#447 (comment) just like the repository manager has? Is "All works" going to be confusing? |
Comment by hannahfrost @ggeisler See @jcoyne 's comment above. The question is what should appear on an admin set Manager's Works page? This Manager may not be able to see All Works in the repository, and may not have any works of their own to see. Do they get a different tab? |
Comment by ggeisler @hannahfrost @jcoyne Yeah, I see the issue. Maybe a third tab is the right approach?
|
@jcoyne @hannahfrost @ggeisler How much design do you think is needed for this ticket? Is @ggeisler's comment above sufficient to make this actionable? |
@hannahfrost OK, great. I'll consider adding to this week's scope depending on how quickly folks move on existing tickets. If not, next week. |
One addendum to my previous comment where I listed three tabs:
In case it wasn't clear from that comment, I believe a given user should never see more than two of the three tabs:
|
@ggeisler That makes sense. I am going to move this to the Ready column |
I may have mistakenly added extra baggage to this ticket. I think we have two related needs:
@hannahfrost @jcoyne @ggeisler Thus:
|
Original Description Issue by hannahfrost Expected behaviorI am a Manager of the default admin set. When I am on the dashboard, I expect to see any works deposited to that admin set listed on the Works page, under the Repository Contents. I expect to see works that have been submitted after the time I was granted the role of Manager I expect to see works that have been submitted, regardless of whether they are in active or not in active workflow. Actual behaviorMy works page is blank. Related to #853 |
I updated the acceptance criteria of this issue. (See issue description.) It's now ready to be picket up. Thanks, @jcoyne. |
@vantuyls Can you confirm that this ticket is still independently needed and useful, and that the need hasn't been subsumed into some other ticket somewhere? I don't think it has, but you may know otherwise. |
I don't see a related issue elsewhere. this is functionality we currently see in Collection Extensions work - @elrayle does the implementation of Managed Works come out of CE work or are you leveraging previous work for that? |
This work may be done as part of #1705 If someone has cycles, this could be tested in nurax. Cc: @hannahfrost @aaron-collier @jcoyne |
I tested this in nurax just now and confirmed that this change has been implemented. Closing the ticket. Thanks, all! |
I am a Manager of one or more Admin Sets, and I am not a Repository Admin. When I click over to
/dashboard/my/works
, I expect to see two tabs:Managed Works
andYour Works
. The former tab is a new tab that shows me all works deposited to the Admin Sets I manage. I expect to see all works that have been submitted, regardless of what workflow the works are in, or whether or not they are suppressed.The design of this tab should follow the design of the
All Works
tab, with the same filters, pagination, and search controls.To repeat: the Repository Admin should never see this tab. Every user should see one, or at most two, tabs on the
/dashboard/my/works
page.The text was updated successfully, but these errors were encountered: