Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As an Admin Set Manager, I should be able to view and act upon works in Admin Sets I manage in a new "Managed Works" tab #965

Closed
mjgiarlo opened this issue May 12, 2017 · 16 comments
Labels
Collection impacts the Collection part of PCDM Model enhancement feedback needed user interface
Milestone

Comments

@mjgiarlo
Copy link
Member

mjgiarlo commented May 12, 2017

I am a Manager of one or more Admin Sets, and I am not a Repository Admin. When I click over to /dashboard/my/works, I expect to see two tabs: Managed Works and Your Works. The former tab is a new tab that shows me all works deposited to the Admin Sets I manage. I expect to see all works that have been submitted, regardless of what workflow the works are in, or whether or not they are suppressed.

The design of this tab should follow the design of the All Works tab, with the same filters, pagination, and search controls.

To repeat: the Repository Admin should never see this tab. Every user should see one, or at most two, tabs on the /dashboard/my/works page.

@mjgiarlo
Copy link
Member Author

Comment by jcoyne
Friday May 12, 2017 at 16:28 GMT


@hannahfrost this seems just like #855, but "as an admin set manager" instead of "as a repository administrator". Is that correct?

@mjgiarlo
Copy link
Member Author

Comment by jcoyne
Friday May 12, 2017 at 16:32 GMT


@hannahfrost is there some reason this is in hyku and not hyrax?

Additionally, should an "admin set manager" get the "All works" tab on this page? samvera/hyku#447 (comment) just like the repository manager has? Is "All works" going to be confusing?

@mjgiarlo
Copy link
Member Author

Comment by hannahfrost
Friday May 12, 2017 at 17:03 GMT


@ggeisler See @jcoyne 's comment above. The question is what should appear on an admin set Manager's Works page? This Manager may not be able to see All Works in the repository, and may not have any works of their own to see. Do they get a different tab?

@mjgiarlo
Copy link
Member Author

Comment by ggeisler
Friday May 12, 2017 at 17:14 GMT


@hannahfrost @jcoyne Yeah, I see the issue. Maybe a third tab is the right approach?

  • All Works - for repository manager - everything in the repository
  • Managed Works - all works the user can manage by virtue of being an admin set manager for one or more admin sets
  • Your Works - works deposited by or shared with the user

@mjgiarlo
Copy link
Member Author

@jcoyne @hannahfrost @ggeisler How much design do you think is needed for this ticket? Is @ggeisler's comment above sufficient to make this actionable?

@hannahfrost
Copy link

@mjgiarlo @jcoyne @ggeisler I believe this to be actionable without further discussion.

@mjgiarlo
Copy link
Member Author

@hannahfrost OK, great. I'll consider adding to this week's scope depending on how quickly folks move on existing tickets. If not, next week.

@ggeisler
Copy link
Contributor

One addendum to my previous comment where I listed three tabs:

  • All Works - for repository manager - everything in the repository
  • Managed Works - all works the user can manage by virtue of being an admin set manager for one or more admin sets
  • Your Works - works deposited by or shared with the user

In case it wasn't clear from that comment, I believe a given user should never see more than two of the three tabs:

  • If user is a Repository manager (or other user with ability to manage all works in the repo): All Works and Your Works tabs
  • If user is Admin set manager (a user that is manager or one or more admin sets): Managed Works and Your Works tabs
  • If normal user: just Your Works tab

@hannahfrost
Copy link

@ggeisler That makes sense. I am going to move this to the Ready column

@mjgiarlo
Copy link
Member Author

mjgiarlo commented May 31, 2017

I may have mistakenly added extra baggage to this ticket. I think we have two related needs:

  1. As an Admin Set Manager, I should be able to view works in the Admin Sets I manage independent of the works that I have deposited. I believe what @ggeisler wrote above works 💯 for this.
  2. As a Repository Manager and an Admin Set Manager, I should be able to view works in the Admin Sets I manage independent of the works that I have deposited and I should be able to pick out those works from the list of All Works relatively easily. I believe this is already accommodated via the "Collection" filter here:

screenshot from 2017-05-31 12-26-47

@hannahfrost @jcoyne @ggeisler Thus:

  1. I'm back to thinking this issue is now ready, and should focus on (1) above. Sorry that I confused things.
  2. Should we re-label the "Collection" filter above to "Administrative Set" since this list includes AdminSets and we're in the dashboard side of the UI? (I think this is, or maybe should be, Filter collections on Works dashboard page, instead of admin sets #1086.)

@mjgiarlo
Copy link
Member Author

mjgiarlo commented Jun 5, 2017

Original Description

Issue by hannahfrost
Friday May 12, 2017 at 16:24 GMT
Originally opened as samvera/hyku#1111


Expected behavior

I am a Manager of the default admin set. When I am on the dashboard, I expect to see any works deposited to that admin set listed on the Works page, under the Repository Contents.

I expect to see works that have been submitted after the time I was granted the role of Manager

I expect to see works that have been submitted, regardless of whether they are in active or not in active workflow.

Actual behavior

My works page is blank.

screenshot 2017-05-12 09 20 55

Related to #853

@mjgiarlo
Copy link
Member Author

mjgiarlo commented Jun 5, 2017

I updated the acceptance criteria of this issue. (See issue description.) It's now ready to be picket up. Thanks, @jcoyne.

@mjgiarlo mjgiarlo changed the title Manager of an admin set does not see works deposited to the admin set on the Works page As an Admin Set Manager, I should be able to view and act upon works in Admin Sets I manage in a new "Managed Works" tab Jun 5, 2017
@vantuyls vantuyls modified the milestones: 2.0.0, 2.x series Sep 20, 2017
@hannahfrost
Copy link

hannahfrost commented Nov 29, 2017

@vantuyls Can you confirm that this ticket is still independently needed and useful, and that the need hasn't been subsumed into some other ticket somewhere? I don't think it has, but you may know otherwise.

@vantuyls
Copy link

I don't see a related issue elsewhere. this is functionality we currently see in Collection Extensions work - @elrayle does the implementation of Managed Works come out of CE work or are you leveraging previous work for that?

@mjgiarlo
Copy link
Member Author

This work may be done as part of #1705

If someone has cycles, this could be tested in nurax. Cc: @hannahfrost @aaron-collier @jcoyne

@hannahfrost
Copy link

I tested this in nurax just now and confirmed that this change has been implemented. Closing the ticket. Thanks, all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Collection impacts the Collection part of PCDM Model enhancement feedback needed user interface
Projects
None yet
Development

No branches or pull requests

4 participants