fixing assignment of rdf_subjects in #attributes= #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -77,6 +77,7 @@ def final_parent | |||
|
|
|||
| def attributes=(values) | |||
| raise ArgumentError, "values must be a Hash, you provided #{values.class}" unless values.kind_of? Hash | |||
| set_subject!(values.with_indifferent_access.delete(:id)) if values.with_indifferent_access.has_key?(:id) and node? | |||
There was a problem hiding this comment.
Can you put the result of values.with_indifferent_access into a local variable and use it on this line and the next?
Subjects for Rdf::Resources created directly with #attributes= (i.e. not build) were not getting set. This was causing some nodes with assigned rdf_subjects to be treated as bnodes. Adds tests for assignment of rdf_subjects.
jcoyne
added a commit
that referenced
this pull request
Apr 11, 2014
fixing assignment of rdf_subjects in #attributes=
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subjects for Rdf::Resources created directly with #attributes= (i.e.
not build) were not getting set. This was causing some nodes with
assigned rdf_subjects to be treated as bnodes. Adds tests for assignment
of ids.