Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test matrix. Drop Rails 4.1, add 5.1 #166

Merged
merged 5 commits into from Jul 5, 2017
Merged

Update test matrix. Drop Rails 4.1, add 5.1 #166

merged 5 commits into from Jul 5, 2017

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented May 5, 2017

No description provided.

@jcoyne
Don't generate test dependencies
77907ee 
In Rails 5.1 this causes an old version of capybara to be installed
@jcoyne
Copy link
Member Author

jcoyne commented May 9, 2017

@cbeer I think the 5.1 build will depend on cbeer/engine_cart#76

@jcoyne
Copy link
Member Author

jcoyne commented May 9, 2017 •
edited

@cbeer FYI, I fixed the capybara thing in rails/rails@943efa3

@coveralls
Copy link

coveralls commented Jul 5, 2017 •
edited

Coverage Status

Coverage remained the same at 85.586% when pulling 0893ffb on test_matrix into 322c8dc on master.

@awead awead merged commit 2e04643 into master Jul 5, 2017
@awead awead deleted the test_matrix branch July 5, 2017 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awead awead awead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jcoyne @coveralls @awead @cbeer