Fields displayed on search results come from config #1954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
force-pushed
the
no_hard_code_attributes
branch
2 times, most recently
from
4898712
to
469e1e9
Compare
Instead of requiring implementers to override a view template to change the values that display on the search results page, use the blacklight configuration as it was intended. This will pave the way for dynamic configuration features in the future. There are also a few changes here that make the views more agnostic about the model type by moving generic_work partials default partials Fixes #1947
| <tr> | ||
| <th><span class="attribute-label h4">Depositor:</span></th> | ||
| <td> | ||
| <% if work.proxy_depositor %> |
There was a problem hiding this comment.
Where is this logic in the new stuff?
There was a problem hiding this comment.
Presently it's just displaying proxy_depositor as Depositor if it exists. If it doesn't exist, it only displays the Owner field. I think that makes sense. Why do we want to see the depositor if it's the same as the owner?
There was a problem hiding this comment.
For consistency, but I'm not that attached to this behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@projecthydra/sufia-code-reviewers
Instead of requiring implementers to override a view template to change
the values that display on the search results page, use the Blacklight
configuration as it was intended. This will pave the way for dynamic
configuration features in the future.
There are also a few changes here that make the views more agnostic
about the model type by moving generic_work partials default partials
Fixes #1947