Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Primeros cambios a sufia.es.yml para su traducción #2772

Closed
wants to merge 5 commits into from
Closed

Primeros cambios a sufia.es.yml para su traducción #2772

wants to merge 5 commits into from

Conversation

ejrivero
Copy link

Fixes #issuenumber ; refs #issuenumber

Present tense short summary (50 characters or less)

More detailed description, if necessary. Try to be as descriptive as you can: even if you think that the PR content is obvious, it may not be obvious to others. Include tracebacks if helpful, and be sure to call out any bits of the PR that may be work-in-progress.

Description can have multiple paragraphs and you can use code examples inside:

class PostsController
  def index
    respond_with Post.limit(10)
  end
end

Changes proposed in this pull request:

@projecthydra/sufia-code-reviewers

Primeros cambios a sufia.es.yml para su traducción, aún faltan bastantes términos

jcoyne and others added 2 commits October 10, 2016 11:01
@jcoyne
Add the ability to switch to a different language
e57f795
@ejrivero
Primeros cambios a sufia.es.yml para su traducción
84319d8 
Primeros cambios a sufia.es.yml para su traducción, aún faltan bastantes términos
@mjgiarlo
Copy link
Member

Thank you, @ejrivero! I am reviewing with the Hydra Steering group whether YAML contributions require contributor license agreements. I'll reply again as soon as I know more.

👏

@wickr
Copy link
Contributor

wickr commented Oct 11, 2016

@ejrivero @mjgiarlo looks like there's a duplicate set of keys, starting at line #394 they start repeating, with a new :es and :sufia and more.

@mjgiarlo
Copy link
Member

Good call, @wickr. @ejrivero: would you mind taking a look at that and pushing a change to your branch?

@ejrivero
Update in sufia.es.yml
42df81a 
Spanish update, may contain translation misconceptions for several spanish speaking countries.
@mjgiarlo
Copy link
Member

@ejrivero Are there any updates to share re: licensing agreements? We're eager to get your PR merged. 😄

luisgreg99
luisgreg99 reviewed Oct 17, 2016
View reviewed changes
config/locales/sufia.es.yml
menu: "Panel de Control"
my: "Mi Panel de Control"
highlights: "Aspectos destacados"
transfers: "Transferirencias"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean "Transferencias"?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, thanks.

luisgreg99
luisgreg99 reviewed Oct 17, 2016
View reviewed changes
config/locales/sufia.es.yml
works:
menu: "Trabajos"
new: "Nuevo"
my: "Mi Trabajos"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be "Mis Trabajos"

luisgreg99
luisgreg99 reviewed Oct 17, 2016
View reviewed changes
config/locales/sufia.es.yml
authorize_proxies: "Autorizar Proxies"
current_proxies: "Proxies actuales"
proxy_user: "Usuario de Proxy"
transfer_of_ownership: "Transferirencia de propiedad"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "Transferencia de propiedad" looks better :)

luisgreg99
luisgreg99 reviewed Oct 17, 2016
View reviewed changes
config/locales/sufia.es.yml
header: Crear nuevos Trabajos en lote
in_collections: Estos Trabajos en Colecciones
in_this_work: Otros Trabajos en este Trabajo
in_other_works: Este Trabajo en otrosTrabajos
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space character: "Este Trabajo en otros Trabajos"

@mjgiarlo
Copy link
Member

I chatted with Alberto today and he thinks they'll be able to submit signed CLAs by the end of this week.

@mjgiarlo
Copy link
Member

@ejrivero What do you think of @luisgreg99's suggestions above?

@ejrivero
Update errors in translation
3030c83 
Fixed errors thanks to @luisgreg99, "Transferirencias" to "Transferencias"(103), "Mi Trabajos" to "Mis Trabajos"(108), "Transferirencia de propiedad" to "Transferencia de propiedad"(131), "Este Trabajo en otrosTrabajos" to "Este Trabajo en otros Trabajos"(248).
@ejrivero
Minor changes
e24bdb7 
Error fix 'Guardar' to 'Actualizar'(443).
ejrivero
ejrivero commented Oct 27, 2016
View reviewed changes
config/locales/sufia.es.yml
submit:
admin_set:
create: 'Guardar'
update: 'Guardar'
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update -> Actualizar

@mjgiarlo
Copy link
Member

This PR is now unblocked; @ejrivero is now a licensed Hydra contributor!

@mjgiarlo
Copy link
Member

I'm porting this to Hyrax.

@mjgiarlo mjgiarlo self-assigned this Dec 13, 2016
@mjgiarlo
Copy link
Member

Replaced by samvera/hyrax#33. Thanks, @ejrivero!

@mjgiarlo mjgiarlo closed this Dec 13, 2016
@mjgiarlo mjgiarlo mentioned this pull request Dec 13, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisgreg99 luisgreg99 luisgreg99 left review comments

@mjgiarlo mjgiarlo mjgiarlo approved these changes

Assignees

@mjgiarlo mjgiarlo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ejrivero @mjgiarlo @wickr @luisgreg99 @carolyncole @jcoyne