Fixes #950: Add default npm directory to PATH. #951
Conversation
|
@pranavkm would be good if you could take quick look at this one. The code looks reasonable to me. I tried just it in Azure using Private Extension, and the correct npm was on the path. |
| /// </remarks> | ||
| internal static string ResolveNodePath() | ||
| { | ||
| string programFiles = SystemEnvironment.GetFolderPath(SystemEnvironment.SpecialFolder.ProgramFilesX86); | ||
|
|
||
| string nodePath = Path.Combine(programFiles, "nodejs", "0.10.5", "node.exe"); | ||
| string nodePath = Path.Combine(programFiles, "nodejs", DefaultNodeVersion, "node.exe"); |
There was a problem hiding this comment.
Can't help but notice DefaultNodeVersion and DefaultNpmVersion are hardcoded in the constant in this file. For DefaultNodeVersion, we should have a tracking bug to adjust it in Public Kudu once we ship S25QFE. However, Private Kudu should already use the latest one (0.10.21).
For DefaultNpmVersion, we have two choices. 1. hardcode it as well but with a comment to adjust together with DefaultNodeVersion. 2. look at npm text of corresponding default Node. 1 is more optimized but room for human error. thought?
There was a problem hiding this comment.
We talked with Pranav yesterday, and it's a tricky code path. For now, we decided to keep it as 0.10.5 (both in public & private). But note that this is different from the Azure default of 0.10.21 (and matching npm), which are used in different scenarios. Yes, it's a bit complicated :)
Fixes #950: Add default npm directory to PATH.
If [Program Files (x86)]\npm[Default npm version]\npm.cmd exists, then add its directory to PATH for the build and debug console environment.