Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request [internal]: Universally fix up the Javac.storeEnd table #2691

Comments

@rzwitserloot
Copy link
Collaborator

rzwitserloot commented Jan 2, 2021

Lombok appears to not always properly add generated nodes to Javac's storeEnd table. This doesn't do much (positions of generated nodes are perpetually in a state of limbo, as so many tools make assumptions that do not hold, such as that no 2 exclusive nodes can share a start position, or that nodes have non-zero length), but it should help a little bit sometimes. It is hard to know what the impact is (it'll impact compiler plugins of all stripes, most likely) for example:

I'm pretty sure it's worth doing this update and then deal with issues as they are raised if doing this causes other tooling to do bizarre things. Most likely it causes other tools to shift from exceptions to undesired reporting on generated code, but we can then start filing requests with those libraries to add facilities for ignoring generated code, and add documentation to the site to explain how to set it up (if we can't convince the project maintainers of things like errorprone to recognize lombok itself and bake into their code that lombok means: generated, so, skip).

@Rawi01
Copy link
Collaborator

Rawi01 commented Jan 2, 2021

If you haven't started with this yet, I would work on this one. Most likely this will be a pretty huge refctoring as every handler that generates something new has to be updated.

@rzwitserloot
Copy link
Collaborator Author

You got the green light from me, I haven't started on this at all, nor has @rspilker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment