[Eclipse 4.27] Lombok ignores lombok.config #3332

snjeza · 2023-01-19T01:54:31Z

Related issues:

lombok.config ignored in 1.14.0 redhat-developer/vscode-java#2887
Extract ECJ compiler code from jdt.core to ecj bundle and make ecj a real plug-in eclipse-jdt/eclipse.jdt.core#181

Related Eclipse N&N - https://www.eclipse.org/eclipse/news/4.27/jdt.php#ecj-separated-from-core

Steps to reproduce:

download Eclipse 4.27M1 - https://download.eclipse.org/eclipse/downloads/drops4/S-4.27M1-202301041800/
install m2e - https://download.eclipse.org/technology/m2e/snapshots/latest/
add lombok-1.18.24 agent to the Eclipse VM arguments
import vscode-java-issue.zip

You will see LOG cannot be resolve.
The issue can't be reproduced in Eclipse 4.26

The text was updated successfully, but these errors were encountered:

snjeza · 2023-01-19T02:19:41Z

A potential patch:

diff --git a/src/core/lombok/eclipse/EclipseAST.java b/src/core/lombok/eclipse/EclipseAST.java
index 4a0854a4..5ac5b816 100644
--- a/src/core/lombok/eclipse/EclipseAST.java
+++ b/src/core/lombok/eclipse/EclipseAST.java
@@ -21,7 +21,10 @@
  */
 package lombok.eclipse;
 
+import static lombok.eclipse.handlers.EclipseHandlerUtil.*;
+
 import java.io.File;
+import java.lang.reflect.Constructor;
 import java.lang.reflect.Field;
 import java.lang.reflect.Method;
 import java.net.URI;
@@ -30,13 +33,6 @@ import java.util.Collection;
 import java.util.Collections;
 import java.util.List;
 
-import lombok.core.AST;
-import lombok.core.LombokImmutableList;
-import static lombok.eclipse.handlers.EclipseHandlerUtil.*;
-import lombok.permit.Permit;
-
-import org.eclipse.core.resources.ResourcesPlugin;
-import org.eclipse.core.runtime.Path;
 import org.eclipse.jdt.internal.compiler.CompilationResult;
 import org.eclipse.jdt.internal.compiler.ast.ASTNode;
 import org.eclipse.jdt.internal.compiler.ast.AbstractMethodDeclaration;
@@ -55,11 +51,25 @@ import org.eclipse.jdt.internal.compiler.ast.TypeDeclaration;
 import org.eclipse.jdt.internal.compiler.ast.TypeReference;
 import org.eclipse.jdt.internal.compiler.ast.Wildcard;
 
+import lombok.core.AST;
+import lombok.core.LombokImmutableList;
+import lombok.permit.Permit;
+
 /**
  * Wraps around Eclipse's internal AST view to add useful features as well as the ability to visit parents from children,
  * something Eclipse own AST system does not offer.
  */
 public class EclipseAST extends AST<EclipseAST, EclipseNode, ASTNode> {
+	private static ClassLoader jdtCoreClassLoader;
+
+	public static ClassLoader getJdtCoreClassLoader() {
+		return jdtCoreClassLoader;
+	}
+
+	public static void setJdtCoreClassLoader(ClassLoader jdtCoreClassLoader) {
+		EclipseAST.jdtCoreClassLoader = jdtCoreClassLoader;
+	}
+
 	/**
 	 * Creates a new EclipseAST of the provided Compilation Unit.
 	 * 
@@ -188,7 +198,41 @@ public class EclipseAST extends AST<EclipseAST, EclipseNode, ASTNode> {
 				return null;
 			}
 			try {
-				return ResourcesPlugin.getWorkspace().getRoot().getFile(new Path(path)).getLocationURI();
+				if (jdtCoreClassLoader != null) {
+					Class<?> resourcePlugin = jdtCoreClassLoader.loadClass("org.eclipse.core.resources.ResourcesPlugin");
+					if (resourcePlugin != null) {
+						Method getWorkspace = resourcePlugin.getMethod("getWorkspace", new Class<?>[0]);
+						Object workspace = getWorkspace.invoke(resourcePlugin,  new Object[0]);
+						if (workspace != null) {
+							Method getRoot = workspace.getClass().getMethod("getRoot", new Class<?>[0]);
+							Object root = getRoot.invoke(workspace,   new Object[0]);
+							if (root != null) {
+								Class<?> pathClass = jdtCoreClassLoader.loadClass("org.eclipse.core.runtime.Path");
+								if (pathClass != null) {
+									Constructor<? extends Object> constructor = pathClass.getConstructor(path.getClass());
+									if (constructor != null) {
+										Object pathObject = constructor.newInstance(path);
+										if (pathObject != null) {
+											Class<?> iPath = jdtCoreClassLoader.loadClass("org.eclipse.core.runtime.IPath");
+											Method getFile = root.getClass().getSuperclass().getMethod("getFile", iPath);
+											if (getFile != null) {
+												Object fileObject = getFile.invoke(root, pathObject);
+												if (fileObject != null) {
+													Method getLocationUri = fileObject.getClass().getMethod("getLocationURI", new Class<?>[0]);
+													Object uri = getLocationUri.invoke(fileObject,  new Object[0]);
+													if (uri instanceof URI) {
+														return (URI)uri;
+													}
+												}
+											}
+										}
+									}
+								}
+							}
+						}
+					}
+				}
+				return null; // return ResourcesPlugin.getWorkspace().getRoot().getFile(new Path(path)).getLocationURI();
 			} catch (Exception e) {
 				// One of the exceptions that can occur is IllegalStateException (during getWorkspace())
 				// if you try to run this while eclipse is shutting down.
diff --git a/src/launch/lombok/launch/Main.java b/src/launch/lombok/launch/Main.java
index af65bdf8..774f7775 100644
--- a/src/launch/lombok/launch/Main.java
+++ b/src/launch/lombok/launch/Main.java
@@ -24,6 +24,8 @@ package lombok.launch;
 import java.lang.reflect.InvocationTargetException;
 import java.util.Arrays;
 
+import lombok.eclipse.EclipseAST;
+
 class Main {
 	private static ShadowClassLoader classLoader;
 	
@@ -37,6 +39,7 @@ class Main {
 	static synchronized void prependClassLoader(ClassLoader loader) {
 		getShadowClassLoader();
 		classLoader.prependParent(loader);
+		EclipseAST.setJdtCoreClassLoader(classLoader);
 	}
 	
 	public static void main(String[] args) throws Throwable {

Rawi01 · 2023-01-21T00:30:08Z

@snjeza Thanks for the report and the workaround.

I had already noticed the separation of the packages but I thought I had time until the release of the next Eclipse version to investigate the impact on Lombok. Seems like I was wrong about that... Do you know if you plan to update to other preview versions in the future?

I hope that we can fix this fast but I guess we also need to change the test system because of the new dependency...

I also noticed that there are some lombok specific changes in jdtls. If there is anything we can do to optimize the support for jdtls please let us know.

snjeza · 2023-01-21T00:55:08Z

@Rawi01 I have created a PR for you. The PR should work with older versions of JDT.

I also noticed that there are some lombok specific changes in jdtls. If there is anything we can do to optimize the support for jdtls please let us know.

cc @jdneo @XiaoYuhao

The latest eclipse version properly splits the jdt.core module and the compiler. To load jdt.core classes during compilation the compiler SCL needs a reference to the jdt.core SCL.

testforstephen · 2023-03-07T02:12:01Z

I also noticed that there are some lombok specific changes in jdtls. If there is anything we can do to optimize the support for jdtls please let us know.

Hi @Rawi01, This is Jinbo, one of project lead of jdtls project. Yes, we have integrated the Lombok support in jdtls by default by using lombok-1.18.24.jar. This benefits Lombok users a lot, thanks for the great work on lombok project.

And usually jdtls offers a monthly release cadence and we are willing to integrate new versions of Lombok as soon as they are ready.

I'm wondering there is a way to speed up this lombok patch as it has affected lots of vscode Java users?

luca-bassoricci · 2023-03-17T10:03:59Z

Is there any ETA?

MagnesiaReal · 2023-03-18T08:10:04Z

Downgrade the version of eclipse to 2022-09 or 2022-12, it works for me.

The latest eclipse version properly splits the jdt.core module and the compiler. To load jdt.core classes during compilation the compiler SCL needs a reference to the jdt.core SCL.

s3curitybug · 2023-03-21T22:21:28Z

Could we get a release with this? I upgraded my Eclipse and I'm having troubles reverting the upgrade, so I cannot work. I guess there are more people in this situation.

rspilker · 2023-03-22T12:51:06Z

If I am correct, the fix has already been merged. We expect to publish an edge release later today.

rzwitserloot · 2023-03-23T13:25:31Z

Available on edge.

danibs · 2023-03-25T13:49:49Z

I tried with Eclipse:
Version: 2023-03 (4.27.0)
Build id: 20230309-1520

Lombok:
Manifest-Version: 1.0
Ant-Version: Apache Ant 1.7.1
Created-By: 14.3-b01-101 (Apple Inc.)
Premain-Class: lombok.launch.Agent
Agent-Class: lombok.launch.Agent
Can-Redefine-Classes: true
Main-Class: lombok.launch.Main
Lombok-Version: 1.18.27
Automatic-Module-Name: lombok

As you can see, still doesn't work. setC1() return void instead of class it-self

thomseno · 2023-03-25T14:29:49Z

I tried with Eclipse: Version: 2023-03 (4.27.0) Build id: 20230309-1520

Lombok: Manifest-Version: 1.0 Ant-Version: Apache Ant 1.7.1 Created-By: 14.3-b01-101 (Apple Inc.) Premain-Class: lombok.launch.Agent Agent-Class: lombok.launch.Agent Can-Redefine-Classes: true Main-Class: lombok.launch.Main Lombok-Version: 1.18.27 Automatic-Module-Name: lombok

As you can see, still doesn't work. setC1() return void instead of class it-self

Maybe I'm missing something, but isn't that the definition of a setter? 🤔

danibs · 2023-03-25T14:54:08Z

Maybe I'm missing something, but isn't that the definition of a setter? thinking

Not using Lombok 😉 (when it works)

thomseno · 2023-03-25T17:47:04Z

Maybe I'm missing something, but isn't that the definition of a setter? thinking

Not using Lombok 😉 (when it works)

🫣 My bad, wasn’t aware of the @Accessors feature.

danibs · 2023-03-27T07:10:42Z

Sorry, my mistake! 😢
The .ini file was configured with the wrong path of Lombok...
Fixed that, it works for me too.

Sorry again...

The latest eclipse version properly splits the jdt.core module and the compiler. To load jdt.core classes during compilation the compiler SCL needs a reference to the jdt.core SCL.

mxmlnglt · 2023-04-27T08:59:35Z

Available on edge.

Repo URL is down... you can only download the .jar by yourself... see #3414

janrieke · 2023-05-26T10:13:36Z

Lombok 1.18.28 has been released and includes this bugfix.

mxmlnglt · 2023-05-26T11:23:28Z

Lombok 1.18.28 has been released and includes this bugfix.

OK great!!! (at last...!)

sandipubale · 2023-09-28T15:16:54Z

I had same problem while using 1.18.4, however, after using version 1.18.24 all problems vanished.

snjeza mentioned this issue Jan 19, 2023

lombok.config ignored in 1.14.0 redhat-developer/vscode-java#2887

Closed

fbricon mentioned this issue Jan 19, 2023

jdtls 1.19 broke lombok.config eclipse-jdtls/eclipse.jdt.ls#2409

Closed

snjeza mentioned this issue Jan 21, 2023

[Eclipse 4.27] Lombok ignores lombok.config #3335

Closed

Rawi01 mentioned this issue Feb 8, 2023

Prepend jdt.core SCL to compiler SCL #3347

Merged

snjeza mentioned this issue Feb 27, 2023

IntelliCode and compilation failure due to Lombok configuration not detected since v1.12.0 redhat-developer/vscode-java#2962

Open

snjeza mentioned this issue Mar 7, 2023

Support for val in lombok redhat-developer/vscode-java#2983

Closed

dstango mentioned this issue Mar 16, 2023

[BUG] Lombok stop working on Eclipse 4.18.0 #3374

Closed

thomseno mentioned this issue Mar 20, 2023

Lombok and spotless-maven-plugin Issues spring-projects/sts4#1008

Closed

rspilker closed this as completed in #3347 Mar 21, 2023

rzwitserloot added this to the next-version milestone Mar 23, 2023

Rawi01 mentioned this issue Mar 23, 2023

[BUG] lombok.config file not taken in account on Eclipse 2023-03 fresh install #3380

Closed

danibs mentioned this issue Mar 25, 2023

[Eclipse 4.27] Lombok ignores lombok.config #3382

Closed

janrieke mentioned this issue Mar 27, 2023

[BUG] Eclipse 2023-03 regress - lombok.config not found #3386

Closed

Rawi01 pinned this issue Mar 28, 2023

testforstephen mentioned this issue Mar 30, 2023

Adopt the lombok@1.18.27 edge release redhat-developer/vscode-java#3031

Merged

This was referenced Apr 13, 2023

classloader bug #3403

Closed

[BUG] Lombok ignores lombok.config #3406

Closed

mxmlnglt mentioned this issue Apr 21, 2023

[BUG] https://projectlombok.org/edge-releases not available? #3414

Closed

pbodnar mentioned this issue Jun 24, 2023

[BUG] Autocomplete for val variables stops working "randomly" in Eclipse #3440

Closed

rspilker unpinned this issue Sep 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Eclipse 4.27] Lombok ignores lombok.config #3332

[Eclipse 4.27] Lombok ignores lombok.config #3332

snjeza commented Jan 19, 2023 •

edited

snjeza commented Jan 19, 2023

Rawi01 commented Jan 21, 2023

snjeza commented Jan 21, 2023

testforstephen commented Mar 7, 2023

luca-bassoricci commented Mar 17, 2023

MagnesiaReal commented Mar 18, 2023

s3curitybug commented Mar 21, 2023

rspilker commented Mar 22, 2023 •

edited

rzwitserloot commented Mar 23, 2023

danibs commented Mar 25, 2023 •

edited

thomseno commented Mar 25, 2023

danibs commented Mar 25, 2023 •

edited

thomseno commented Mar 25, 2023 •

edited

danibs commented Mar 27, 2023

mxmlnglt commented Apr 27, 2023

janrieke commented May 26, 2023

mxmlnglt commented May 26, 2023

sandipubale commented Sep 28, 2023

[Eclipse 4.27] Lombok ignores lombok.config #3332

[Eclipse 4.27] Lombok ignores lombok.config #3332

Comments

snjeza commented Jan 19, 2023 • edited

snjeza commented Jan 19, 2023

Rawi01 commented Jan 21, 2023

snjeza commented Jan 21, 2023

testforstephen commented Mar 7, 2023

luca-bassoricci commented Mar 17, 2023

MagnesiaReal commented Mar 18, 2023

s3curitybug commented Mar 21, 2023

rspilker commented Mar 22, 2023 • edited

rzwitserloot commented Mar 23, 2023

danibs commented Mar 25, 2023 • edited

thomseno commented Mar 25, 2023

danibs commented Mar 25, 2023 • edited

thomseno commented Mar 25, 2023 • edited

danibs commented Mar 27, 2023

mxmlnglt commented Apr 27, 2023

janrieke commented May 26, 2023

mxmlnglt commented May 26, 2023

sandipubale commented Sep 28, 2023

snjeza commented Jan 19, 2023 •

edited

rspilker commented Mar 22, 2023 •

edited

danibs commented Mar 25, 2023 •

edited

danibs commented Mar 25, 2023 •

edited

thomseno commented Mar 25, 2023 •

edited