SuperBuilder fix for Builder.Default, final, and NonNull fields #1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctlombok#1347 is fixed now (javac)
…ctlombok#1347 is fixed now (ecj)
assign value once so that final fields work (ecj)
|
Was just about to submit a ticket for this issue. Hope this gets pulled in soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change,
@SuperBuilderworks also for fields that arefinaland@Builder.Default. Furthermore, the@NonNullcode also checks the default value for!= null.This fixes #1800.
This PR includes PR #1818, so you may want to review/merge #1818 first (or just review/merge this one to have it all).