[Feature] staticConstructor should use already defined private constr… #2119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot! To be legally covered, can you please add your name to the AUTHORS file and adjust the pull request? I'm still reviewing the code, looks good so far. Great that you included the tests for both delombok and ecj! |
rspilker
reviewed
May 6, 2019
| staticConstrRequired ? AccessLevel.PRIVATE : level, typeNode, fieldsToParam, forceDefaults, | ||
| sourceNode, onConstructor); | ||
| injectMethod(typeNode, constr); | ||
| if (skipIfConstructorExists != SkipIfConstructorExists.NO && constructorExists(typeNode) != MemberExistsResult.NOT_EXISTS) { |
There was a problem hiding this comment.
Why
if (condition) {
// generateStatic()
} else {
// createConstructor
// generateStatic()
}
instead of
if (!condition) {
// createConstructor
}
//generateStatic()
I think the latter is simpler.
There was a problem hiding this comment.
Fixed good catch 👍
|
I've added a comment in the code. This comment applies for both Eclipse and Javac. |
…uctor if available
daliclass
force-pushed
the
feature_value_annotation_should_use_already_defined_private_constructor
branch
from
635fc26
to
09ed5a8
Compare
Added to Authors, gotta love tests 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…uctor if available
to solve issue #2100