Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing labels and colors in charts #26

Closed
wang-boyu opened this issue Sep 12, 2023 · 1 comment · Fixed by #37
Closed

Missing labels and colors in charts #26

wang-boyu opened this issue Sep 12, 2023 · 1 comment · Fixed by #37

Comments

@wang-boyu
Copy link
Member

Describe the bug

In the Schelling model, chart label is shown as "undefined" and colors are not rendered correctly:

Screenshot 2023-09-12 at 10 54 59 AM

Expected behavior

Chart label should be "happy" and color should be black, as specified in the code: https://github.com/projectmesa/mesa-examples/blob/6f3e077f2d3050e11852abfa29954eb06ef0a057/examples/schelling/server.py#L30

To Reproduce

Run the Schelling model from mesa-examples repo via mesa runserver.

Additional context

Probably introduced in projectmesa/mesa#1685

The settings used in Mesa are "Color" and "Label" (with capital "C" and "L"). They were mapped to "borderColor" and "label" before the PR. With the PR they are used as-is.

@rht
Copy link
Collaborator

rht commented Oct 16, 2023

Updated #37 to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants