Skip to content

Commit

Permalink
frontend: Explicitly remove jQuery dependency
Browse files Browse the repository at this point in the history
  • Loading branch information
rht committed Jun 7, 2022
1 parent ef653fa commit b6538ed
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
1 change: 0 additions & 1 deletion mesa/visualization/templates/modular_template.html
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ <h4 class="modal-title">About {{ model_name }}</h4>
</div>

<!-- Bottom-load all JavaScript dependencies -->
<script src="/static/js/external/jquery-2.2.4.min.js"></script>
<script src="/static/external/bootstrap-5.1.3-dist/js/bootstrap.bundle.min.js"></script>
<script src="/static/external/bootstrap-slider-11.0.2/dist/bootstrap-slider.min.js"></script>

Expand Down
6 changes: 1 addition & 5 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def ensure_JS_dep(dirname, url):


def ensure_JS_dep_single(url, out_name=None):
# Used for downloading e.g. jQuery single file
# Used for downloading e.g. D3.js single file
if out_name is None:
out_name = url.split("/")[-1]
dst_path = os.path.join(external_dir_single, out_name)
Expand Down Expand Up @@ -79,10 +79,6 @@ def ensure_JS_dep_single(url, out_name=None):
f"https://github.com/seiyria/bootstrap-slider/archive/refs/tags/v{bootstrap_slider_version}.zip",
)

jquery_version = "2.2.4"
ensure_JS_dep_single(
f"https://code.jquery.com/jquery-{jquery_version}.min.js",
)
# Important: when updating the D3 version, make sure to update the constant
# D3_JS_FILE in mesa/visualization/ModularVisualization.py.
d3_version = "7.4.3"
Expand Down

0 comments on commit b6538ed

Please sign in to comment.