Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS refactor: We should replace all usage of var x = ... with const / let in the JS code #1232

Closed
rht opened this issue Apr 3, 2022 · 8 comments
Closed

JS refactor: We should replace all usage of var x = ... with const / let in the JS code #1232

rht opened this issue Apr 3, 2022 · 8 comments
Labels
good first issue help wanted

Comments

@rht
Copy link
Contributor

rht commented Apr 3, 2022

No description provided.

@SangameshItagi
Copy link
Contributor

Hi @rht , I can help here

@rht
Copy link
Contributor Author

rht commented Apr 3, 2022

@SangameshItagi sounds good. Make sure to not do one big PR while doing it. It's better to do several small-medium sized PRs so that it is easier to review and merge.

@trickroll trickroll mentioned this issue Apr 4, 2022
Merged
@trickroll
Copy link
Contributor

Tried to tackle a few of the files instead of a big PR!

SangameshItagi added a commit to SangameshItagi/mesa that referenced this issue Apr 5, 2022
@SangameshItagi
Issue projectmesa#1232; Replaced usage of var to const,let in some files
ebff2f9
@SangameshItagi SangameshItagi mentioned this issue Apr 5, 2022
Merged
@rht
Copy link
Contributor Author

rht commented Apr 5, 2022

To avoid duplication of work:

In #1248, @SangameshItagi is working on

  • mesa/visualization/templates/js/CanvasHexModule.js
  • mesa/visualization/templates/js/CanvasModule.js
  • mesa/visualization/templates/js/GridDraw.js
  • mesa/visualization/templates/js/HexDraw.js

In #1246, @trickroll is working on

  • mesa/visualization/templates/js/NetworkModule_sigma.js
  • mesa/visualization/templates/js/PieChartModule.js
  • mesa/visualization/templates/js/TextModule.js

@wang-boyu wang-boyu mentioned this issue Apr 5, 2022
Closed
SangameshItagi added a commit to SangameshItagi/mesa that referenced this issue Apr 5, 2022
@SangameshItagi
Issue projectmesa#1232; Refactor: Replace usage of var with const/let…
ade69d2 
… in some JS files
@rht
Copy link
Contributor Author

rht commented Apr 7, 2022 •
edited

Remaining JS files up for grabs:

  • BarChartModule.js
  • ChartModule.js
  • NetworkModule_d3.js
  • runcontrol.js

This was referenced Apr 7, 2022
Closed
Merged
@rht
Copy link
Contributor Author

rht commented Apr 7, 2022

Closed via #1265.

@rht rht closed this as completed Apr 7, 2022
@rht rht reopened this Apr 8, 2022
@rht
Copy link
Contributor Author

rht commented Apr 8, 2022

I missed one more JS file: there is still InteractionHandler.js. However, we should wait until #1266 is merged.

@trickroll trickroll mentioned this issue Apr 10, 2022
Merged
@rht
Copy link
Contributor Author

rht commented Apr 10, 2022

Closed via #1273.

@rht rht closed this as completed Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rht @trickroll @SangameshItagi